diff options
author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-05-12 12:01:50 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-05-16 22:11:52 -0400 |
commit | 3e4de4ec4cfea40994b47a79767610153edbf45b (patch) | |
tree | a255becfd76282a397dd5eab974f08cf234b1b62 | |
parent | 3b1fff08038bd0792b1aa1e9703b2dd0512a3fd0 (diff) |
perf core: Add perf_callchain_store_context() helper
We need have different helpers to account how many contexts we have in
the sample and for real addresses, so do it now as a prep patch, to
ease review.
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/n/tip-q964tnyuqrxw5gld18vizs3c@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | arch/powerpc/perf/callchain.c | 6 | ||||
-rw-r--r-- | include/linux/perf_event.h | 2 | ||||
-rw-r--r-- | kernel/events/callchain.c | 4 |
3 files changed, 7 insertions, 5 deletions
diff --git a/arch/powerpc/perf/callchain.c b/arch/powerpc/perf/callchain.c index f68f213dc36c..f62597dbd757 100644 --- a/arch/powerpc/perf/callchain.c +++ b/arch/powerpc/perf/callchain.c | |||
@@ -76,7 +76,7 @@ perf_callchain_kernel(struct perf_callchain_entry_ctx *entry, struct pt_regs *re | |||
76 | next_ip = regs->nip; | 76 | next_ip = regs->nip; |
77 | lr = regs->link; | 77 | lr = regs->link; |
78 | level = 0; | 78 | level = 0; |
79 | perf_callchain_store(entry, PERF_CONTEXT_KERNEL); | 79 | perf_callchain_store_context(entry, PERF_CONTEXT_KERNEL); |
80 | 80 | ||
81 | } else { | 81 | } else { |
82 | if (level == 0) | 82 | if (level == 0) |
@@ -274,7 +274,7 @@ static void perf_callchain_user_64(struct perf_callchain_entry_ctx *entry, | |||
274 | read_user_stack_64(&uregs[PT_R1], &sp)) | 274 | read_user_stack_64(&uregs[PT_R1], &sp)) |
275 | return; | 275 | return; |
276 | level = 0; | 276 | level = 0; |
277 | perf_callchain_store(entry, PERF_CONTEXT_USER); | 277 | perf_callchain_store_context(entry, PERF_CONTEXT_USER); |
278 | perf_callchain_store(entry, next_ip); | 278 | perf_callchain_store(entry, next_ip); |
279 | continue; | 279 | continue; |
280 | } | 280 | } |
@@ -473,7 +473,7 @@ static void perf_callchain_user_32(struct perf_callchain_entry_ctx *entry, | |||
473 | read_user_stack_32(&uregs[PT_R1], &sp)) | 473 | read_user_stack_32(&uregs[PT_R1], &sp)) |
474 | return; | 474 | return; |
475 | level = 0; | 475 | level = 0; |
476 | perf_callchain_store(entry, PERF_CONTEXT_USER); | 476 | perf_callchain_store_context(entry, PERF_CONTEXT_USER); |
477 | perf_callchain_store(entry, next_ip); | 477 | perf_callchain_store(entry, next_ip); |
478 | continue; | 478 | continue; |
479 | } | 479 | } |
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 3803bb1a862b..2024b14cc2b1 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h | |||
@@ -1079,6 +1079,8 @@ extern void put_callchain_buffers(void); | |||
1079 | 1079 | ||
1080 | extern int sysctl_perf_event_max_stack; | 1080 | extern int sysctl_perf_event_max_stack; |
1081 | 1081 | ||
1082 | #define perf_callchain_store_context(ctx, context) perf_callchain_store(ctx, context) | ||
1083 | |||
1082 | static inline int perf_callchain_store(struct perf_callchain_entry_ctx *ctx, u64 ip) | 1084 | static inline int perf_callchain_store(struct perf_callchain_entry_ctx *ctx, u64 ip) |
1083 | { | 1085 | { |
1084 | if (ctx->nr < ctx->max_stack) { | 1086 | if (ctx->nr < ctx->max_stack) { |
diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c index 8774ff86debb..ca645736a983 100644 --- a/kernel/events/callchain.c +++ b/kernel/events/callchain.c | |||
@@ -200,7 +200,7 @@ get_perf_callchain(struct pt_regs *regs, u32 init_nr, bool kernel, bool user, | |||
200 | 200 | ||
201 | if (kernel && !user_mode(regs)) { | 201 | if (kernel && !user_mode(regs)) { |
202 | if (add_mark) | 202 | if (add_mark) |
203 | perf_callchain_store(&ctx, PERF_CONTEXT_KERNEL); | 203 | perf_callchain_store_context(&ctx, PERF_CONTEXT_KERNEL); |
204 | perf_callchain_kernel(&ctx, regs); | 204 | perf_callchain_kernel(&ctx, regs); |
205 | } | 205 | } |
206 | 206 | ||
@@ -217,7 +217,7 @@ get_perf_callchain(struct pt_regs *regs, u32 init_nr, bool kernel, bool user, | |||
217 | goto exit_put; | 217 | goto exit_put; |
218 | 218 | ||
219 | if (add_mark) | 219 | if (add_mark) |
220 | perf_callchain_store(&ctx, PERF_CONTEXT_USER); | 220 | perf_callchain_store_context(&ctx, PERF_CONTEXT_USER); |
221 | perf_callchain_user(&ctx, regs); | 221 | perf_callchain_user(&ctx, regs); |
222 | } | 222 | } |
223 | } | 223 | } |