diff options
| author | Josh Poimboeuf <jpoimboe@redhat.com> | 2017-10-03 21:10:36 -0400 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2017-10-04 02:02:18 -0400 |
| commit | 3dd40cb320fee7c23b574ab821ce140ccd1281c9 (patch) | |
| tree | ddc592ec376e781577876d659e559192515a9dbf | |
| parent | d81fa669e3de7eb8a631d7d95dac5fbcb2bf9d4e (diff) | |
objtool: Upgrade libelf-devel warning to error for CONFIG_ORC_UNWINDER
With CONFIG_ORC_UNWINDER, if the user doesn't have libelf-devel
installed, and they don't see the make warning, their ORC unwinder will
be silently broken. Upgrade the warning to an error.
Reported-and-tested-by: Borislav Petkov <bp@alien8.de>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/d9dfc39fb8240998820f9efb233d283a1ee96084.1507079417.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
| -rw-r--r-- | Makefile | 6 |
1 files changed, 5 insertions, 1 deletions
| @@ -933,7 +933,11 @@ ifdef CONFIG_STACK_VALIDATION | |||
| 933 | ifeq ($(has_libelf),1) | 933 | ifeq ($(has_libelf),1) |
| 934 | objtool_target := tools/objtool FORCE | 934 | objtool_target := tools/objtool FORCE |
| 935 | else | 935 | else |
| 936 | $(warning "Cannot use CONFIG_STACK_VALIDATION, please install libelf-dev, libelf-devel or elfutils-libelf-devel") | 936 | ifdef CONFIG_ORC_UNWINDER |
| 937 | $(error "Cannot generate ORC metadata for CONFIG_ORC_UNWINDER=y, please install libelf-dev, libelf-devel or elfutils-libelf-devel") | ||
| 938 | else | ||
| 939 | $(warning "Cannot use CONFIG_STACK_VALIDATION=y, please install libelf-dev, libelf-devel or elfutils-libelf-devel") | ||
| 940 | endif | ||
| 937 | SKIP_STACK_VALIDATION := 1 | 941 | SKIP_STACK_VALIDATION := 1 |
| 938 | export SKIP_STACK_VALIDATION | 942 | export SKIP_STACK_VALIDATION |
| 939 | endif | 943 | endif |