diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2016-09-21 18:37:42 -0400 |
---|---|---|
committer | Miklos Szeredi <mszeredi@redhat.com> | 2016-10-01 01:32:33 -0400 |
commit | 3daa9c51651f2631be373840db0f82a8efb1c63d (patch) | |
tree | 0298d00eb0e9f60176b795bac6c7fee3c57dc39c | |
parent | 29433a2991fa636c1fcd5bf5893cf92c37e0b26c (diff) |
fuse_ioctl_copy_user(): don't open-code copy_page_{to,from}_iter()
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
-rw-r--r-- | fs/fuse/file.c | 30 |
1 files changed, 7 insertions, 23 deletions
diff --git a/fs/fuse/file.c b/fs/fuse/file.c index 3988b43c2f5a..4c1db6ce7c48 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c | |||
@@ -2339,31 +2339,15 @@ static int fuse_ioctl_copy_user(struct page **pages, struct iovec *iov, | |||
2339 | 2339 | ||
2340 | while (iov_iter_count(&ii)) { | 2340 | while (iov_iter_count(&ii)) { |
2341 | struct page *page = pages[page_idx++]; | 2341 | struct page *page = pages[page_idx++]; |
2342 | size_t todo = min_t(size_t, PAGE_SIZE, iov_iter_count(&ii)); | 2342 | size_t copied; |
2343 | void *kaddr; | ||
2344 | 2343 | ||
2345 | kaddr = kmap(page); | 2344 | if (!to_user) |
2346 | 2345 | copied = copy_page_from_iter(page, 0, PAGE_SIZE, &ii); | |
2347 | while (todo) { | 2346 | else |
2348 | char __user *uaddr = ii.iov->iov_base + ii.iov_offset; | 2347 | copied = copy_page_to_iter(page, 0, PAGE_SIZE, &ii); |
2349 | size_t iov_len = ii.iov->iov_len - ii.iov_offset; | ||
2350 | size_t copy = min(todo, iov_len); | ||
2351 | size_t left; | ||
2352 | |||
2353 | if (!to_user) | ||
2354 | left = copy_from_user(kaddr, uaddr, copy); | ||
2355 | else | ||
2356 | left = copy_to_user(uaddr, kaddr, copy); | ||
2357 | |||
2358 | if (unlikely(left)) | ||
2359 | return -EFAULT; | ||
2360 | |||
2361 | iov_iter_advance(&ii, copy); | ||
2362 | todo -= copy; | ||
2363 | kaddr += copy; | ||
2364 | } | ||
2365 | 2348 | ||
2366 | kunmap(page); | 2349 | if (unlikely(copied != PAGE_SIZE && iov_iter_count(&ii))) |
2350 | return -EFAULT; | ||
2367 | } | 2351 | } |
2368 | 2352 | ||
2369 | return 0; | 2353 | return 0; |