diff options
author | Hannes Reinecke <hare@suse.de> | 2017-04-28 04:04:04 -0400 |
---|---|---|
committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2017-05-02 01:21:53 -0400 |
commit | 3d035237a57777b7672eb116133da01493b607c1 (patch) | |
tree | 5c1f4b5a48fd0851f74fc684fae856625767308c | |
parent | c0dcafd8c52e0c36588d4d14c2ef4288830bc461 (diff) |
target: fixup error message in target_tg_pt_gp_tg_pt_gp_id_store()
When setting up an ALUA target port group with an invalid ID the
error message
kstrtoul() returned -22 for tg_pt_gp_id
is displayed, which is not really helpful.
Convert it to something sane.
And while we're at it, join the messages onto a single line.
Signed-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Bart van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
-rw-r--r-- | drivers/target/target_core_configfs.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c index 9e6ba367ae70..0326607e5ab8 100644 --- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c | |||
@@ -2677,13 +2677,13 @@ static ssize_t target_tg_pt_gp_tg_pt_gp_id_store(struct config_item *item, | |||
2677 | 2677 | ||
2678 | ret = kstrtoul(page, 0, &tg_pt_gp_id); | 2678 | ret = kstrtoul(page, 0, &tg_pt_gp_id); |
2679 | if (ret < 0) { | 2679 | if (ret < 0) { |
2680 | pr_err("kstrtoul() returned %d for" | 2680 | pr_err("ALUA tg_pt_gp_id: invalid value '%s' for tg_pt_gp_id\n", |
2681 | " tg_pt_gp_id\n", ret); | 2681 | page); |
2682 | return ret; | 2682 | return ret; |
2683 | } | 2683 | } |
2684 | if (tg_pt_gp_id > 0x0000ffff) { | 2684 | if (tg_pt_gp_id > 0x0000ffff) { |
2685 | pr_err("ALUA tg_pt_gp_id: %lu exceeds maximum:" | 2685 | pr_err("ALUA tg_pt_gp_id: %lu exceeds maximum: 0x0000ffff\n", |
2686 | " 0x0000ffff\n", tg_pt_gp_id); | 2686 | tg_pt_gp_id); |
2687 | return -EINVAL; | 2687 | return -EINVAL; |
2688 | } | 2688 | } |
2689 | 2689 | ||