diff options
author | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2016-03-21 10:47:48 -0400 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2016-03-22 18:13:36 -0400 |
commit | 3bbf8fe3ae0845af9192118753c2399efe531832 (patch) | |
tree | e35adff645878fdc538139b32ca4f687db76c935 | |
parent | 999f572983de5e1a4ee9f42daa51b5448f12dd64 (diff) |
cpufreq: Always update current frequency before startig governor
Make policy->cur match the current frequency returned by the driver's
->get() callback before starting the governor in case they went out of
sync in the meantime and drop the piece of code attempting to
resync policy->cur with the real frequency of the boot CPU from
cpufreq_resume() as it serves no purpose any more (and it's racy and
super-ugly anyway).
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
-rw-r--r-- | drivers/cpufreq/cpufreq.c | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index ffdb7fca5bb7..b87596b591b3 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c | |||
@@ -1612,17 +1612,6 @@ void cpufreq_resume(void) | |||
1612 | __func__, policy); | 1612 | __func__, policy); |
1613 | } | 1613 | } |
1614 | } | 1614 | } |
1615 | |||
1616 | /* | ||
1617 | * schedule call cpufreq_update_policy() for first-online CPU, as that | ||
1618 | * wouldn't be hotplugged-out on suspend. It will verify that the | ||
1619 | * current freq is in sync with what we believe it to be. | ||
1620 | */ | ||
1621 | policy = cpufreq_cpu_get_raw(cpumask_first(cpu_online_mask)); | ||
1622 | if (WARN_ON(!policy)) | ||
1623 | return; | ||
1624 | |||
1625 | schedule_work(&policy->update); | ||
1626 | } | 1615 | } |
1627 | 1616 | ||
1628 | /** | 1617 | /** |
@@ -1950,6 +1939,9 @@ static int cpufreq_start_governor(struct cpufreq_policy *policy) | |||
1950 | { | 1939 | { |
1951 | int ret; | 1940 | int ret; |
1952 | 1941 | ||
1942 | if (cpufreq_driver->get && !cpufreq_driver->setpolicy) | ||
1943 | cpufreq_update_current_freq(policy); | ||
1944 | |||
1953 | ret = cpufreq_governor(policy, CPUFREQ_GOV_START); | 1945 | ret = cpufreq_governor(policy, CPUFREQ_GOV_START); |
1954 | return ret ? ret : cpufreq_governor(policy, CPUFREQ_GOV_LIMITS); | 1946 | return ret ? ret : cpufreq_governor(policy, CPUFREQ_GOV_LIMITS); |
1955 | } | 1947 | } |