diff options
author | Hou Tao <houtao1@huawei.com> | 2017-07-12 03:25:01 -0400 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2017-07-12 10:32:02 -0400 |
commit | 38c9140740eb0993924b676a111c164903163b1e (patch) | |
tree | 079c5055fc98bf7a3beb4b3d00cd5e48e1665393 | |
parent | 3b06b1a7448ee4e8e51dae3938774735404e51fb (diff) |
bfq: fix typos in comments about B-WF2Q+ algorithm
The start time of eligible entity should be less than or equal to
the current virtual time, and the entity in idle tree has a finish
time being greater than the current virtual time.
Signed-off-by: Hou Tao <houtao1@huawei.com>
Reviewed-by: Paolo Valente <paolo.valente@linaro.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r-- | block/bfq-iosched.h | 2 | ||||
-rw-r--r-- | block/bfq-wf2q.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h index 8fd83b885774..63e771ab56d8 100644 --- a/block/bfq-iosched.h +++ b/block/bfq-iosched.h | |||
@@ -52,7 +52,7 @@ struct bfq_entity; | |||
52 | struct bfq_service_tree { | 52 | struct bfq_service_tree { |
53 | /* tree for active entities (i.e., those backlogged) */ | 53 | /* tree for active entities (i.e., those backlogged) */ |
54 | struct rb_root active; | 54 | struct rb_root active; |
55 | /* tree for idle entities (i.e., not backlogged, with V <= F_i)*/ | 55 | /* tree for idle entities (i.e., not backlogged, with V < F_i)*/ |
56 | struct rb_root idle; | 56 | struct rb_root idle; |
57 | 57 | ||
58 | /* idle entity with minimum F_i */ | 58 | /* idle entity with minimum F_i */ |
diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c index 5ec05cd42b80..979f8f21b7e2 100644 --- a/block/bfq-wf2q.c +++ b/block/bfq-wf2q.c | |||
@@ -1297,7 +1297,7 @@ static void bfq_update_vtime(struct bfq_service_tree *st, u64 new_value) | |||
1297 | * | 1297 | * |
1298 | * This function searches the first schedulable entity, starting from the | 1298 | * This function searches the first schedulable entity, starting from the |
1299 | * root of the tree and going on the left every time on this side there is | 1299 | * root of the tree and going on the left every time on this side there is |
1300 | * a subtree with at least one eligible (start >= vtime) entity. The path on | 1300 | * a subtree with at least one eligible (start <= vtime) entity. The path on |
1301 | * the right is followed only if a) the left subtree contains no eligible | 1301 | * the right is followed only if a) the left subtree contains no eligible |
1302 | * entities and b) no eligible entity has been found yet. | 1302 | * entities and b) no eligible entity has been found yet. |
1303 | */ | 1303 | */ |