aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarek Szyprowski <m.szyprowski@samsung.com>2016-11-16 04:04:55 -0500
committerMauro Carvalho Chehab <mchehab@s-opensource.com>2016-11-30 06:20:00 -0500
commit387e08e2021022e764a235df6c1f0ed3d861f711 (patch)
tree3fab8d8b8b2b82dfa85d9135b80b861019c20367
parent7e55a016fac080118a634179405c821c31d8bd2e (diff)
[media] s5p-mfc: Kill all IS_ERR_OR_NULL in clocks management code
After commit "s5p-mfc: Fix clock management in s5p_mfc_release function" all clocks related functions are called only when MFC device is really available, so there is no additional check needed for NULL gate clocks. This patch simplifies the code and kills IS_ERR_OR_NULL macro usage. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
-rw-r--r--drivers/media/platform/s5p-mfc/s5p_mfc_pm.c13
1 files changed, 4 insertions, 9 deletions
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c b/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c
index 11a918eb7564..b514584cf00d 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c
@@ -91,16 +91,12 @@ void s5p_mfc_final_pm(struct s5p_mfc_dev *dev)
91 91
92int s5p_mfc_clock_on(void) 92int s5p_mfc_clock_on(void)
93{ 93{
94 int ret = 0;
95
96 atomic_inc(&clk_ref); 94 atomic_inc(&clk_ref);
97 mfc_debug(3, "+ %d\n", atomic_read(&clk_ref)); 95 mfc_debug(3, "+ %d\n", atomic_read(&clk_ref));
98 96
99 if (!pm->use_clock_gating) 97 if (!pm->use_clock_gating)
100 return 0; 98 return 0;
101 if (!IS_ERR_OR_NULL(pm->clock_gate)) 99 return clk_enable(pm->clock_gate);
102 ret = clk_enable(pm->clock_gate);
103 return ret;
104} 100}
105 101
106void s5p_mfc_clock_off(void) 102void s5p_mfc_clock_off(void)
@@ -110,8 +106,7 @@ void s5p_mfc_clock_off(void)
110 106
111 if (!pm->use_clock_gating) 107 if (!pm->use_clock_gating)
112 return; 108 return;
113 if (!IS_ERR_OR_NULL(pm->clock_gate)) 109 clk_disable(pm->clock_gate);
114 clk_disable(pm->clock_gate);
115} 110}
116 111
117int s5p_mfc_power_on(void) 112int s5p_mfc_power_on(void)
@@ -122,14 +117,14 @@ int s5p_mfc_power_on(void)
122 if (ret) 117 if (ret)
123 return ret; 118 return ret;
124 119
125 if (!pm->use_clock_gating && !IS_ERR_OR_NULL(pm->clock_gate)) 120 if (!pm->use_clock_gating)
126 ret = clk_enable(pm->clock_gate); 121 ret = clk_enable(pm->clock_gate);
127 return ret; 122 return ret;
128} 123}
129 124
130int s5p_mfc_power_off(void) 125int s5p_mfc_power_off(void)
131{ 126{
132 if (!pm->use_clock_gating && !IS_ERR_OR_NULL(pm->clock_gate)) 127 if (!pm->use_clock_gating)
133 clk_disable(pm->clock_gate); 128 clk_disable(pm->clock_gate);
134 return pm_runtime_put_sync(pm->device); 129 return pm_runtime_put_sync(pm->device);
135} 130}