diff options
| author | Marek Vasut <marex@denx.de> | 2016-09-19 15:30:27 -0400 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2016-09-20 13:55:28 -0400 |
| commit | 35ddb15757cd1c817e424c6252d2f11f268cfebf (patch) | |
| tree | 38f6af1853a64c9feb403814ff0f37bf521532f8 | |
| parent | 0effb8651ee3b00513fbba9ef3912bbcbbd38af6 (diff) | |
ASoC: fsl_spdif: use flat regmap cache
Same as commit ce492b3b8f99cf9d2f807ec22d8805c996a09503
Subject: drm/fsl-dcu: use flat regmap cache
Using flat regmap cache instead of RB-tree to avoid the following
lockdep warning on driver load:
WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2871 lockdep_trace_alloc+0x104/0x128
DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags))
The RB-tree regmap cache needs to allocate new space on first
writes. However, allocations in an atomic context (e.g. when a
spinlock is held) are not allowed. The function regmap_write
calls map->lock, which acquires a spinlock in the fast_io case.
Since the driver uses MMIO, the regmap bus of type regmap_mmio
is being used which has fast_io set to true.
Signed-off-by: Marek Vasut <marex@denx.de>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/fsl/fsl_spdif.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index beec7934a265..1ff467c9598a 100644 --- a/sound/soc/fsl/fsl_spdif.c +++ b/sound/soc/fsl/fsl_spdif.c | |||
| @@ -1103,7 +1103,7 @@ static const struct regmap_config fsl_spdif_regmap_config = { | |||
| 1103 | .readable_reg = fsl_spdif_readable_reg, | 1103 | .readable_reg = fsl_spdif_readable_reg, |
| 1104 | .volatile_reg = fsl_spdif_volatile_reg, | 1104 | .volatile_reg = fsl_spdif_volatile_reg, |
| 1105 | .writeable_reg = fsl_spdif_writeable_reg, | 1105 | .writeable_reg = fsl_spdif_writeable_reg, |
| 1106 | .cache_type = REGCACHE_RBTREE, | 1106 | .cache_type = REGCACHE_FLAT, |
| 1107 | }; | 1107 | }; |
| 1108 | 1108 | ||
| 1109 | static u32 fsl_spdif_txclk_caldiv(struct fsl_spdif_priv *spdif_priv, | 1109 | static u32 fsl_spdif_txclk_caldiv(struct fsl_spdif_priv *spdif_priv, |
