diff options
| author | Arend Van Spriel <arend.vanspriel@broadcom.com> | 2017-06-16 04:36:35 -0400 |
|---|---|---|
| committer | Kalle Valo <kvalo@codeaurora.org> | 2017-06-16 04:52:36 -0400 |
| commit | 35abcd4f9f303ac4f10f99b3f7e993e5f2e6fa37 (patch) | |
| tree | bb3e0b03af4cd384f1ca3709a0447b7b406e2af4 | |
| parent | a2b7a622d6292b693544d7c94bb5d11c3f4676f8 (diff) | |
brcmfmac: fix uninitialized warning in brcmf_usb_probe_phase2()
This fixes the following warning:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c: In function
'brcmf_usb_probe_phase2':
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:1198:2:
warning: 'devinfo' may be used uninitialized in this function
[-Wmaybe-uninitialized]
mutex_unlock(&devinfo->dev_init_lock);
Fixes: 6d0507a777fb ("brcmfmac: add parameter to pass error code in firmware callback")
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
| -rw-r--r-- | drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c index 9ce3b55c3ffe..0eea48e73331 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | |||
| @@ -1164,14 +1164,13 @@ static void brcmf_usb_probe_phase2(struct device *dev, int ret, | |||
| 1164 | void *nvram, u32 nvlen) | 1164 | void *nvram, u32 nvlen) |
| 1165 | { | 1165 | { |
| 1166 | struct brcmf_bus *bus = dev_get_drvdata(dev); | 1166 | struct brcmf_bus *bus = dev_get_drvdata(dev); |
| 1167 | struct brcmf_usbdev_info *devinfo; | 1167 | struct brcmf_usbdev_info *devinfo = bus->bus_priv.usb->devinfo; |
| 1168 | 1168 | ||
| 1169 | if (ret) | 1169 | if (ret) |
| 1170 | goto error; | 1170 | goto error; |
| 1171 | 1171 | ||
| 1172 | brcmf_dbg(USB, "Start fw downloading\n"); | 1172 | brcmf_dbg(USB, "Start fw downloading\n"); |
| 1173 | 1173 | ||
| 1174 | devinfo = bus->bus_priv.usb->devinfo; | ||
| 1175 | ret = check_file(fw->data); | 1174 | ret = check_file(fw->data); |
| 1176 | if (ret < 0) { | 1175 | if (ret < 0) { |
| 1177 | brcmf_err("invalid firmware\n"); | 1176 | brcmf_err("invalid firmware\n"); |
