aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCristian Birsan <cristian.birsan@microchip.com>2016-08-08 11:44:22 -0400
committerMark Brown <broonie@kernel.org>2016-08-09 08:43:33 -0400
commit359a2f17604e2c1c8938be2bba32a8cef9cf6303 (patch)
tree3523caf97e7e0c9d993ebb066881511533027638
parent1ea975cf1ef57b1e44c0aec4820f60bb3b60904b (diff)
regmap: debugfs: Add support for dumping write only device registers
Add support for dumping write only device registers in debugfs. This is useful for audio codecs that have write only registers (like WM8731). The logic that decides if a value can be printed is moved to regmap_printable() function to allow for easier future updates. Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com> Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--drivers/base/regmap/regmap-debugfs.c16
1 files changed, 13 insertions, 3 deletions
diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c
index 1ee3d40861c7..36ce3511c733 100644
--- a/drivers/base/regmap/regmap-debugfs.c
+++ b/drivers/base/regmap/regmap-debugfs.c
@@ -77,6 +77,17 @@ static void regmap_debugfs_free_dump_cache(struct regmap *map)
77 } 77 }
78} 78}
79 79
80static bool regmap_printable(struct regmap *map, unsigned int reg)
81{
82 if (regmap_precious(map, reg))
83 return false;
84
85 if (!regmap_readable(map, reg) && !regmap_cached(map, reg))
86 return false;
87
88 return true;
89}
90
80/* 91/*
81 * Work out where the start offset maps into register numbers, bearing 92 * Work out where the start offset maps into register numbers, bearing
82 * in mind that we suppress hidden registers. 93 * in mind that we suppress hidden registers.
@@ -105,8 +116,7 @@ static unsigned int regmap_debugfs_get_dump_start(struct regmap *map,
105 if (list_empty(&map->debugfs_off_cache)) { 116 if (list_empty(&map->debugfs_off_cache)) {
106 for (; i <= map->max_register; i += map->reg_stride) { 117 for (; i <= map->max_register; i += map->reg_stride) {
107 /* Skip unprinted registers, closing off cache entry */ 118 /* Skip unprinted registers, closing off cache entry */
108 if (!regmap_readable(map, i) || 119 if (!regmap_printable(map, i)) {
109 regmap_precious(map, i)) {
110 if (c) { 120 if (c) {
111 c->max = p - 1; 121 c->max = p - 1;
112 c->max_reg = i - map->reg_stride; 122 c->max_reg = i - map->reg_stride;
@@ -204,7 +214,7 @@ static ssize_t regmap_read_debugfs(struct regmap *map, unsigned int from,
204 start_reg = regmap_debugfs_get_dump_start(map, from, *ppos, &p); 214 start_reg = regmap_debugfs_get_dump_start(map, from, *ppos, &p);
205 215
206 for (i = start_reg; i <= to; i += map->reg_stride) { 216 for (i = start_reg; i <= to; i += map->reg_stride) {
207 if (!regmap_readable(map, i)) 217 if (!regmap_readable(map, i) && !regmap_cached(map, i))
208 continue; 218 continue;
209 219
210 if (regmap_precious(map, i)) 220 if (regmap_precious(map, i))