diff options
author | Julia Lawall <julia.lawall@lip6.fr> | 2016-08-31 04:05:25 -0400 |
---|---|---|
committer | Alexandre Belloni <alexandre.belloni@free-electrons.com> | 2016-09-01 19:24:06 -0400 |
commit | 34c7b3ac4ccb6a972f81a4102c8ef216ca1fb155 (patch) | |
tree | a3ddef13f50f73d1c031130ac6a8cb1400464d6d | |
parent | 637cac7c139f6433506f38aca85c2bf37ff64787 (diff) |
rtc: constify rtc_class_ops structures
Check for rtc_class_ops structures that are only passed to
devm_rtc_device_register, rtc_device_register,
platform_device_register_data, all of which declare the corresponding
parameter as const. Declare rtc_class_ops structures that have these
properties as const.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct rtc_class_ops i@p = { ... };
@ok@
identifier r.i;
expression e1,e2,e3,e4;
position p;
@@
(
devm_rtc_device_register(e1,e2,&i@p,e3)
|
rtc_device_register(e1,e2,&i@p,e3)
|
platform_device_register_data(e1,e2,e3,&i@p,e4)
)
@bad@
position p != {r.p,ok.p};
identifier r.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct rtc_class_ops i = { ... };
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Acked-by: Hans Ulli Kroll <ulli.kroll@googlemail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
-rw-r--r-- | drivers/rtc/rtc-at32ap700x.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-coh901331.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-davinci.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-digicolor.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-ds1302.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-gemini.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-jz4740.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-mcp795.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-mt6397.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-nuc900.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-omap.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-palmas.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-pcf50633.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-rx6110.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-rx8025.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-spear.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-stmp3xxx.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-tegra.c | 2 | ||||
-rw-r--r-- | drivers/rtc/rtc-twl.c | 2 |
19 files changed, 19 insertions, 19 deletions
diff --git a/drivers/rtc/rtc-at32ap700x.c b/drivers/rtc/rtc-at32ap700x.c index 83ac2337c0f7..de8bf56a41e7 100644 --- a/drivers/rtc/rtc-at32ap700x.c +++ b/drivers/rtc/rtc-at32ap700x.c | |||
@@ -187,7 +187,7 @@ static irqreturn_t at32_rtc_interrupt(int irq, void *dev_id) | |||
187 | return ret; | 187 | return ret; |
188 | } | 188 | } |
189 | 189 | ||
190 | static struct rtc_class_ops at32_rtc_ops = { | 190 | static const struct rtc_class_ops at32_rtc_ops = { |
191 | .read_time = at32_rtc_readtime, | 191 | .read_time = at32_rtc_readtime, |
192 | .set_time = at32_rtc_settime, | 192 | .set_time = at32_rtc_settime, |
193 | .read_alarm = at32_rtc_readalarm, | 193 | .read_alarm = at32_rtc_readalarm, |
diff --git a/drivers/rtc/rtc-coh901331.c b/drivers/rtc/rtc-coh901331.c index 101b7a240e0f..cfc4141d99cd 100644 --- a/drivers/rtc/rtc-coh901331.c +++ b/drivers/rtc/rtc-coh901331.c | |||
@@ -140,7 +140,7 @@ static int coh901331_alarm_irq_enable(struct device *dev, unsigned int enabled) | |||
140 | return 0; | 140 | return 0; |
141 | } | 141 | } |
142 | 142 | ||
143 | static struct rtc_class_ops coh901331_ops = { | 143 | static const struct rtc_class_ops coh901331_ops = { |
144 | .read_time = coh901331_read_time, | 144 | .read_time = coh901331_read_time, |
145 | .set_mmss = coh901331_set_mmss, | 145 | .set_mmss = coh901331_set_mmss, |
146 | .read_alarm = coh901331_read_alarm, | 146 | .read_alarm = coh901331_read_alarm, |
diff --git a/drivers/rtc/rtc-davinci.c b/drivers/rtc/rtc-davinci.c index dba60c1dfce2..caf35567e14c 100644 --- a/drivers/rtc/rtc-davinci.c +++ b/drivers/rtc/rtc-davinci.c | |||
@@ -469,7 +469,7 @@ static int davinci_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alm) | |||
469 | return 0; | 469 | return 0; |
470 | } | 470 | } |
471 | 471 | ||
472 | static struct rtc_class_ops davinci_rtc_ops = { | 472 | static const struct rtc_class_ops davinci_rtc_ops = { |
473 | .ioctl = davinci_rtc_ioctl, | 473 | .ioctl = davinci_rtc_ioctl, |
474 | .read_time = davinci_rtc_read_time, | 474 | .read_time = davinci_rtc_read_time, |
475 | .set_time = davinci_rtc_set_time, | 475 | .set_time = davinci_rtc_set_time, |
diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c index 8d05596a6765..b253bf1b3531 100644 --- a/drivers/rtc/rtc-digicolor.c +++ b/drivers/rtc/rtc-digicolor.c | |||
@@ -159,7 +159,7 @@ static int dc_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) | |||
159 | return 0; | 159 | return 0; |
160 | } | 160 | } |
161 | 161 | ||
162 | static struct rtc_class_ops dc_rtc_ops = { | 162 | static const struct rtc_class_ops dc_rtc_ops = { |
163 | .read_time = dc_rtc_read_time, | 163 | .read_time = dc_rtc_read_time, |
164 | .set_mmss = dc_rtc_set_mmss, | 164 | .set_mmss = dc_rtc_set_mmss, |
165 | .read_alarm = dc_rtc_read_alarm, | 165 | .read_alarm = dc_rtc_read_alarm, |
diff --git a/drivers/rtc/rtc-ds1302.c b/drivers/rtc/rtc-ds1302.c index f5dd09fe5add..0ec4be62322b 100644 --- a/drivers/rtc/rtc-ds1302.c +++ b/drivers/rtc/rtc-ds1302.c | |||
@@ -102,7 +102,7 @@ static int ds1302_rtc_get_time(struct device *dev, struct rtc_time *time) | |||
102 | return rtc_valid_tm(time); | 102 | return rtc_valid_tm(time); |
103 | } | 103 | } |
104 | 104 | ||
105 | static struct rtc_class_ops ds1302_rtc_ops = { | 105 | static const struct rtc_class_ops ds1302_rtc_ops = { |
106 | .read_time = ds1302_rtc_get_time, | 106 | .read_time = ds1302_rtc_get_time, |
107 | .set_time = ds1302_rtc_set_time, | 107 | .set_time = ds1302_rtc_set_time, |
108 | }; | 108 | }; |
diff --git a/drivers/rtc/rtc-gemini.c b/drivers/rtc/rtc-gemini.c index b57505efadbc..688debc14348 100644 --- a/drivers/rtc/rtc-gemini.c +++ b/drivers/rtc/rtc-gemini.c | |||
@@ -110,7 +110,7 @@ static int gemini_rtc_set_time(struct device *dev, struct rtc_time *tm) | |||
110 | return 0; | 110 | return 0; |
111 | } | 111 | } |
112 | 112 | ||
113 | static struct rtc_class_ops gemini_rtc_ops = { | 113 | static const struct rtc_class_ops gemini_rtc_ops = { |
114 | .read_time = gemini_rtc_read_time, | 114 | .read_time = gemini_rtc_read_time, |
115 | .set_time = gemini_rtc_set_time, | 115 | .set_time = gemini_rtc_set_time, |
116 | }; | 116 | }; |
diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c index b2bcfc0bf2e5..5e14651b71a8 100644 --- a/drivers/rtc/rtc-jz4740.c +++ b/drivers/rtc/rtc-jz4740.c | |||
@@ -174,7 +174,7 @@ static int jz4740_rtc_alarm_irq_enable(struct device *dev, unsigned int enable) | |||
174 | return jz4740_rtc_ctrl_set_bits(rtc, JZ_RTC_CTRL_AF_IRQ, enable); | 174 | return jz4740_rtc_ctrl_set_bits(rtc, JZ_RTC_CTRL_AF_IRQ, enable); |
175 | } | 175 | } |
176 | 176 | ||
177 | static struct rtc_class_ops jz4740_rtc_ops = { | 177 | static const struct rtc_class_ops jz4740_rtc_ops = { |
178 | .read_time = jz4740_rtc_read_time, | 178 | .read_time = jz4740_rtc_read_time, |
179 | .set_mmss = jz4740_rtc_set_mmss, | 179 | .set_mmss = jz4740_rtc_set_mmss, |
180 | .read_alarm = jz4740_rtc_read_alarm, | 180 | .read_alarm = jz4740_rtc_read_alarm, |
diff --git a/drivers/rtc/rtc-mcp795.c b/drivers/rtc/rtc-mcp795.c index 025bb33b9cd2..4021fd04cb0a 100644 --- a/drivers/rtc/rtc-mcp795.c +++ b/drivers/rtc/rtc-mcp795.c | |||
@@ -151,7 +151,7 @@ static int mcp795_read_time(struct device *dev, struct rtc_time *tim) | |||
151 | return rtc_valid_tm(tim); | 151 | return rtc_valid_tm(tim); |
152 | } | 152 | } |
153 | 153 | ||
154 | static struct rtc_class_ops mcp795_rtc_ops = { | 154 | static const struct rtc_class_ops mcp795_rtc_ops = { |
155 | .read_time = mcp795_read_time, | 155 | .read_time = mcp795_read_time, |
156 | .set_time = mcp795_set_time | 156 | .set_time = mcp795_set_time |
157 | }; | 157 | }; |
diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c index 44f622c3e048..1a61fa56f3ad 100644 --- a/drivers/rtc/rtc-mt6397.c +++ b/drivers/rtc/rtc-mt6397.c | |||
@@ -301,7 +301,7 @@ exit: | |||
301 | return ret; | 301 | return ret; |
302 | } | 302 | } |
303 | 303 | ||
304 | static struct rtc_class_ops mtk_rtc_ops = { | 304 | static const struct rtc_class_ops mtk_rtc_ops = { |
305 | .read_time = mtk_rtc_read_time, | 305 | .read_time = mtk_rtc_read_time, |
306 | .set_time = mtk_rtc_set_time, | 306 | .set_time = mtk_rtc_set_time, |
307 | .read_alarm = mtk_rtc_read_alarm, | 307 | .read_alarm = mtk_rtc_read_alarm, |
diff --git a/drivers/rtc/rtc-nuc900.c b/drivers/rtc/rtc-nuc900.c index 09fc1c19f0df..b1b6b3041bfb 100644 --- a/drivers/rtc/rtc-nuc900.c +++ b/drivers/rtc/rtc-nuc900.c | |||
@@ -214,7 +214,7 @@ static int nuc900_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) | |||
214 | return 0; | 214 | return 0; |
215 | } | 215 | } |
216 | 216 | ||
217 | static struct rtc_class_ops nuc900_rtc_ops = { | 217 | static const struct rtc_class_ops nuc900_rtc_ops = { |
218 | .read_time = nuc900_rtc_read_time, | 218 | .read_time = nuc900_rtc_read_time, |
219 | .set_time = nuc900_rtc_set_time, | 219 | .set_time = nuc900_rtc_set_time, |
220 | .read_alarm = nuc900_rtc_read_alarm, | 220 | .read_alarm = nuc900_rtc_read_alarm, |
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c index ec2e9c5fb993..cadac8e2aa6b 100644 --- a/drivers/rtc/rtc-omap.c +++ b/drivers/rtc/rtc-omap.c | |||
@@ -469,7 +469,7 @@ static void omap_rtc_power_off(void) | |||
469 | mdelay(2500); | 469 | mdelay(2500); |
470 | } | 470 | } |
471 | 471 | ||
472 | static struct rtc_class_ops omap_rtc_ops = { | 472 | static const struct rtc_class_ops omap_rtc_ops = { |
473 | .read_time = omap_rtc_read_time, | 473 | .read_time = omap_rtc_read_time, |
474 | .set_time = omap_rtc_set_time, | 474 | .set_time = omap_rtc_set_time, |
475 | .read_alarm = omap_rtc_read_alarm, | 475 | .read_alarm = omap_rtc_read_alarm, |
diff --git a/drivers/rtc/rtc-palmas.c b/drivers/rtc/rtc-palmas.c index 6080e0edef63..4bcfb88674d3 100644 --- a/drivers/rtc/rtc-palmas.c +++ b/drivers/rtc/rtc-palmas.c | |||
@@ -225,7 +225,7 @@ static irqreturn_t palmas_rtc_interrupt(int irq, void *context) | |||
225 | return IRQ_HANDLED; | 225 | return IRQ_HANDLED; |
226 | } | 226 | } |
227 | 227 | ||
228 | static struct rtc_class_ops palmas_rtc_ops = { | 228 | static const struct rtc_class_ops palmas_rtc_ops = { |
229 | .read_time = palmas_rtc_read_time, | 229 | .read_time = palmas_rtc_read_time, |
230 | .set_time = palmas_rtc_set_time, | 230 | .set_time = palmas_rtc_set_time, |
231 | .read_alarm = palmas_rtc_read_alarm, | 231 | .read_alarm = palmas_rtc_read_alarm, |
diff --git a/drivers/rtc/rtc-pcf50633.c b/drivers/rtc/rtc-pcf50633.c index e6b6911c8e05..00c31c91b245 100644 --- a/drivers/rtc/rtc-pcf50633.c +++ b/drivers/rtc/rtc-pcf50633.c | |||
@@ -232,7 +232,7 @@ static int pcf50633_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) | |||
232 | return ret; | 232 | return ret; |
233 | } | 233 | } |
234 | 234 | ||
235 | static struct rtc_class_ops pcf50633_rtc_ops = { | 235 | static const struct rtc_class_ops pcf50633_rtc_ops = { |
236 | .read_time = pcf50633_rtc_read_time, | 236 | .read_time = pcf50633_rtc_read_time, |
237 | .set_time = pcf50633_rtc_set_time, | 237 | .set_time = pcf50633_rtc_set_time, |
238 | .read_alarm = pcf50633_rtc_read_alarm, | 238 | .read_alarm = pcf50633_rtc_read_alarm, |
diff --git a/drivers/rtc/rtc-rx6110.c b/drivers/rtc/rtc-rx6110.c index 591793e2b4ac..7c9c08eab5e5 100644 --- a/drivers/rtc/rtc-rx6110.c +++ b/drivers/rtc/rtc-rx6110.c | |||
@@ -317,7 +317,7 @@ static int rx6110_init(struct rx6110_data *rx6110) | |||
317 | return ret; | 317 | return ret; |
318 | } | 318 | } |
319 | 319 | ||
320 | static struct rtc_class_ops rx6110_rtc_ops = { | 320 | static const struct rtc_class_ops rx6110_rtc_ops = { |
321 | .read_time = rx6110_get_time, | 321 | .read_time = rx6110_get_time, |
322 | .set_time = rx6110_set_time, | 322 | .set_time = rx6110_set_time, |
323 | }; | 323 | }; |
diff --git a/drivers/rtc/rtc-rx8025.c b/drivers/rtc/rtc-rx8025.c index 2b85cc7a24e7..91857d8d2df8 100644 --- a/drivers/rtc/rtc-rx8025.c +++ b/drivers/rtc/rtc-rx8025.c | |||
@@ -403,7 +403,7 @@ static int rx8025_alarm_irq_enable(struct device *dev, unsigned int enabled) | |||
403 | return 0; | 403 | return 0; |
404 | } | 404 | } |
405 | 405 | ||
406 | static struct rtc_class_ops rx8025_rtc_ops = { | 406 | static const struct rtc_class_ops rx8025_rtc_ops = { |
407 | .read_time = rx8025_get_time, | 407 | .read_time = rx8025_get_time, |
408 | .set_time = rx8025_set_time, | 408 | .set_time = rx8025_set_time, |
409 | .read_alarm = rx8025_read_alarm, | 409 | .read_alarm = rx8025_read_alarm, |
diff --git a/drivers/rtc/rtc-spear.c b/drivers/rtc/rtc-spear.c index f05ef8568480..e377f42abae7 100644 --- a/drivers/rtc/rtc-spear.c +++ b/drivers/rtc/rtc-spear.c | |||
@@ -343,7 +343,7 @@ static int spear_alarm_irq_enable(struct device *dev, unsigned int enabled) | |||
343 | return ret; | 343 | return ret; |
344 | } | 344 | } |
345 | 345 | ||
346 | static struct rtc_class_ops spear_rtc_ops = { | 346 | static const struct rtc_class_ops spear_rtc_ops = { |
347 | .read_time = spear_rtc_read_time, | 347 | .read_time = spear_rtc_read_time, |
348 | .set_time = spear_rtc_set_time, | 348 | .set_time = spear_rtc_set_time, |
349 | .read_alarm = spear_rtc_read_alarm, | 349 | .read_alarm = spear_rtc_read_alarm, |
diff --git a/drivers/rtc/rtc-stmp3xxx.c b/drivers/rtc/rtc-stmp3xxx.c index e6aaaa52e7fe..d578e40d5a50 100644 --- a/drivers/rtc/rtc-stmp3xxx.c +++ b/drivers/rtc/rtc-stmp3xxx.c | |||
@@ -231,7 +231,7 @@ static int stmp3xxx_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alm) | |||
231 | return 0; | 231 | return 0; |
232 | } | 232 | } |
233 | 233 | ||
234 | static struct rtc_class_ops stmp3xxx_rtc_ops = { | 234 | static const struct rtc_class_ops stmp3xxx_rtc_ops = { |
235 | .alarm_irq_enable = | 235 | .alarm_irq_enable = |
236 | stmp3xxx_alarm_irq_enable, | 236 | stmp3xxx_alarm_irq_enable, |
237 | .read_time = stmp3xxx_rtc_gettime, | 237 | .read_time = stmp3xxx_rtc_gettime, |
diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c index 15ac597d54da..3853ba963bb5 100644 --- a/drivers/rtc/rtc-tegra.c +++ b/drivers/rtc/rtc-tegra.c | |||
@@ -291,7 +291,7 @@ static irqreturn_t tegra_rtc_irq_handler(int irq, void *data) | |||
291 | return IRQ_HANDLED; | 291 | return IRQ_HANDLED; |
292 | } | 292 | } |
293 | 293 | ||
294 | static struct rtc_class_ops tegra_rtc_ops = { | 294 | static const struct rtc_class_ops tegra_rtc_ops = { |
295 | .read_time = tegra_rtc_read_time, | 295 | .read_time = tegra_rtc_read_time, |
296 | .set_time = tegra_rtc_set_time, | 296 | .set_time = tegra_rtc_set_time, |
297 | .read_alarm = tegra_rtc_read_alarm, | 297 | .read_alarm = tegra_rtc_read_alarm, |
diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c index 2dc787dc06c1..176720b7b9e5 100644 --- a/drivers/rtc/rtc-twl.c +++ b/drivers/rtc/rtc-twl.c | |||
@@ -462,7 +462,7 @@ out: | |||
462 | return ret; | 462 | return ret; |
463 | } | 463 | } |
464 | 464 | ||
465 | static struct rtc_class_ops twl_rtc_ops = { | 465 | static const struct rtc_class_ops twl_rtc_ops = { |
466 | .read_time = twl_rtc_read_time, | 466 | .read_time = twl_rtc_read_time, |
467 | .set_time = twl_rtc_set_time, | 467 | .set_time = twl_rtc_set_time, |
468 | .read_alarm = twl_rtc_read_alarm, | 468 | .read_alarm = twl_rtc_read_alarm, |