diff options
author | Joe Carnuccio <joe.carnuccio@qlogic.com> | 2014-09-25 05:16:40 -0400 |
---|---|---|
committer | Christoph Hellwig <hch@lst.de> | 2014-09-25 08:25:02 -0400 |
commit | 349c390f43c63c2c919b81beb84b3a7592f2dd14 (patch) | |
tree | 4238ffd19c13137db1731e4a4a571ab34bdbf825 | |
parent | 4096953054ad4369774f9dadc125ef7a57bb9ed0 (diff) |
qla2xxx: ISP27xx fwdump template error print simplification.
Signed-off-by: Joe Carnuccio <joe.carnuccio@qlogic.com>
Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
-rw-r--r-- | drivers/scsi/qla2xxx/qla_dbg.c | 3 | ||||
-rw-r--r-- | drivers/scsi/qla2xxx/qla_tmpl.c | 31 | ||||
-rw-r--r-- | drivers/scsi/qla2xxx/qla_tmpl.h | 2 |
3 files changed, 9 insertions, 27 deletions
diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c index fff8769f0b33..d60c1c6af6c7 100644 --- a/drivers/scsi/qla2xxx/qla_dbg.c +++ b/drivers/scsi/qla2xxx/qla_dbg.c | |||
@@ -65,6 +65,9 @@ | |||
65 | * | | | 0xb149 | | 65 | * | | | 0xb149 | |
66 | * | MultiQ | 0xc00c | | | 66 | * | MultiQ | 0xc00c | | |
67 | * | Misc | 0xd213 | 0xd011-0xd017 | | 67 | * | Misc | 0xd213 | 0xd011-0xd017 | |
68 | * | | | 0xd021,0xd024 | | ||
69 | * | | | 0xd025,0xd029 | | ||
70 | * | | | 0xd02a,0xd02e | | ||
68 | * | | | 0xd031-0xd0ff | | 71 | * | | | 0xd031-0xd0ff | |
69 | * | | | 0xd101-0xd1fe | | 72 | * | | | 0xd101-0xd1fe | |
70 | * | | | 0xd214-0xd2fe | | 73 | * | | | 0xd214-0xd2fe | |
diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c index d92ee068e802..a8c0c7362e48 100644 --- a/drivers/scsi/qla2xxx/qla_tmpl.c +++ b/drivers/scsi/qla2xxx/qla_tmpl.c | |||
@@ -355,14 +355,9 @@ qla27xx_fwdt_entry_t262(struct scsi_qla_host *vha, | |||
355 | ent->t262.start_addr = start; | 355 | ent->t262.start_addr = start; |
356 | ent->t262.end_addr = end; | 356 | ent->t262.end_addr = end; |
357 | } | 357 | } |
358 | } else if (ent->t262.ram_area == T262_RAM_AREA_DDR_RAM) { | ||
359 | ql_dbg(ql_dbg_misc, vha, 0xd021, | ||
360 | "%s: unsupported ddr ram\n", __func__); | ||
361 | qla27xx_skip_entry(ent, buf); | ||
362 | goto done; | ||
363 | } else { | 358 | } else { |
364 | ql_dbg(ql_dbg_misc, vha, 0xd022, | 359 | ql_dbg(ql_dbg_misc, vha, 0xd022, |
365 | "%s: unknown area %u\n", __func__, ent->t262.ram_area); | 360 | "%s: unknown area %x\n", __func__, ent->t262.ram_area); |
366 | qla27xx_skip_entry(ent, buf); | 361 | qla27xx_skip_entry(ent, buf); |
367 | goto done; | 362 | goto done; |
368 | } | 363 | } |
@@ -377,8 +372,6 @@ qla27xx_fwdt_entry_t262(struct scsi_qla_host *vha, | |||
377 | 372 | ||
378 | dwords = end - start + 1; | 373 | dwords = end - start + 1; |
379 | if (buf) { | 374 | if (buf) { |
380 | ql_dbg(ql_dbg_misc, vha, 0xd024, | ||
381 | "%s: @%lx -> (%lx dwords)\n", __func__, start, dwords); | ||
382 | buf += *len; | 375 | buf += *len; |
383 | qla24xx_dump_ram(vha->hw, start, buf, dwords, &buf); | 376 | qla24xx_dump_ram(vha->hw, start, buf, dwords, &buf); |
384 | } | 377 | } |
@@ -423,13 +416,9 @@ qla27xx_fwdt_entry_t263(struct scsi_qla_host *vha, | |||
423 | count++; | 416 | count++; |
424 | } | 417 | } |
425 | } | 418 | } |
426 | } else if (ent->t263.queue_type == T263_QUEUE_TYPE_ATIO) { | ||
427 | ql_dbg(ql_dbg_misc, vha, 0xd025, | ||
428 | "%s: unsupported atio queue\n", __func__); | ||
429 | qla27xx_skip_entry(ent, buf); | ||
430 | } else { | 419 | } else { |
431 | ql_dbg(ql_dbg_misc, vha, 0xd026, | 420 | ql_dbg(ql_dbg_misc, vha, 0xd026, |
432 | "%s: unknown queue %u\n", __func__, ent->t263.queue_type); | 421 | "%s: unknown queue %x\n", __func__, ent->t263.queue_type); |
433 | qla27xx_skip_entry(ent, buf); | 422 | qla27xx_skip_entry(ent, buf); |
434 | } | 423 | } |
435 | 424 | ||
@@ -524,17 +513,9 @@ qla27xx_fwdt_entry_t268(struct scsi_qla_host *vha, | |||
524 | "%s: missing eft\n", __func__); | 513 | "%s: missing eft\n", __func__); |
525 | qla27xx_skip_entry(ent, buf); | 514 | qla27xx_skip_entry(ent, buf); |
526 | } | 515 | } |
527 | } else if (ent->t268.buf_type == T268_BUF_TYPE_EXCH_BUFOFF) { | ||
528 | ql_dbg(ql_dbg_misc, vha, 0xd029, | ||
529 | "%s: unsupported exchange offload buffer\n", __func__); | ||
530 | qla27xx_skip_entry(ent, buf); | ||
531 | } else if (ent->t268.buf_type == T268_BUF_TYPE_EXTD_LOGIN) { | ||
532 | ql_dbg(ql_dbg_misc, vha, 0xd02a, | ||
533 | "%s: unsupported extended login buffer\n", __func__); | ||
534 | qla27xx_skip_entry(ent, buf); | ||
535 | } else { | 516 | } else { |
536 | ql_dbg(ql_dbg_misc, vha, 0xd02b, | 517 | ql_dbg(ql_dbg_misc, vha, 0xd02b, |
537 | "%s: unknown buf %x\n", __func__, ent->t268.buf_type); | 518 | "%s: unknown buffer %x\n", __func__, ent->t268.buf_type); |
538 | qla27xx_skip_entry(ent, buf); | 519 | qla27xx_skip_entry(ent, buf); |
539 | } | 520 | } |
540 | 521 | ||
@@ -670,13 +651,9 @@ qla27xx_fwdt_entry_t274(struct scsi_qla_host *vha, | |||
670 | count++; | 651 | count++; |
671 | } | 652 | } |
672 | } | 653 | } |
673 | } else if (ent->t274.queue_type == T274_QUEUE_TYPE_ATIO_SHAD) { | ||
674 | ql_dbg(ql_dbg_misc, vha, 0xd02e, | ||
675 | "%s: unsupported atio queue\n", __func__); | ||
676 | qla27xx_skip_entry(ent, buf); | ||
677 | } else { | 654 | } else { |
678 | ql_dbg(ql_dbg_misc, vha, 0xd02f, | 655 | ql_dbg(ql_dbg_misc, vha, 0xd02f, |
679 | "%s: unknown queue %u\n", __func__, ent->t274.queue_type); | 656 | "%s: unknown queue %x\n", __func__, ent->t274.queue_type); |
680 | qla27xx_skip_entry(ent, buf); | 657 | qla27xx_skip_entry(ent, buf); |
681 | } | 658 | } |
682 | 659 | ||
diff --git a/drivers/scsi/qla2xxx/qla_tmpl.h b/drivers/scsi/qla2xxx/qla_tmpl.h index f19856bb873f..141c1c5e73f4 100644 --- a/drivers/scsi/qla2xxx/qla_tmpl.h +++ b/drivers/scsi/qla2xxx/qla_tmpl.h | |||
@@ -214,6 +214,8 @@ struct __packed qla27xx_fwdt_entry { | |||
214 | #define T268_BUF_TYPE_EXTD_TRACE 1 | 214 | #define T268_BUF_TYPE_EXTD_TRACE 1 |
215 | #define T268_BUF_TYPE_EXCH_BUFOFF 2 | 215 | #define T268_BUF_TYPE_EXCH_BUFOFF 2 |
216 | #define T268_BUF_TYPE_EXTD_LOGIN 3 | 216 | #define T268_BUF_TYPE_EXTD_LOGIN 3 |
217 | #define T268_BUF_TYPE_REQ_MIRROR 4 | ||
218 | #define T268_BUF_TYPE_RSP_MIRROR 5 | ||
217 | 219 | ||
218 | #define T274_QUEUE_TYPE_REQ_SHAD 1 | 220 | #define T274_QUEUE_TYPE_REQ_SHAD 1 |
219 | #define T274_QUEUE_TYPE_RSP_SHAD 2 | 221 | #define T274_QUEUE_TYPE_RSP_SHAD 2 |