aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBhaktipriya Shridhar <bhaktipriya96@gmail.com>2015-12-13 10:15:13 -0500
committerJonathan Cameron <jic23@kernel.org>2015-12-19 11:40:55 -0500
commit34708a0ce860fc70112c285cfde717b1d1aed708 (patch)
tree200c5256c3378ebc561deebbb4cfedb82d3c9f85
parent6e17c98a004c921e07bdecdb8cc2320488f88759 (diff)
Staging: iio: accel: sca3000: Fixed NULL comparison style
The variable u8 **rx_p, is a pointer-to-pointer and hence the check should be "if (!*rx_p)" and not "if (!rx_p)". In the earlier version, checkpatch.pl gave the following check, which was incorrect: CHECK: Comparison to NULL could be written "!rx_p" + if (*rx_p == NULL) { Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
-rw-r--r--drivers/staging/iio/accel/sca3000_ring.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c
index 20b878d35ea2..1920dc60cf3d 100644
--- a/drivers/staging/iio/accel/sca3000_ring.c
+++ b/drivers/staging/iio/accel/sca3000_ring.c
@@ -48,7 +48,7 @@ static int sca3000_read_data(struct sca3000_state *st,
48 } 48 }
49 }; 49 };
50 *rx_p = kmalloc(len, GFP_KERNEL); 50 *rx_p = kmalloc(len, GFP_KERNEL);
51 if (*rx_p == NULL) { 51 if (!*rx_p) {
52 ret = -ENOMEM; 52 ret = -ENOMEM;
53 goto error_ret; 53 goto error_ret;
54 } 54 }