diff options
author | Hans de Goede <j.w.r.degoede@gmail.com> | 2018-01-17 03:10:32 -0500 |
---|---|---|
committer | Hans de Goede <hdegoede@redhat.com> | 2018-01-17 04:10:18 -0500 |
commit | 341a0ffceaa44660c43d219a3b2569ebbd7d3ad1 (patch) | |
tree | cc6705c89581e4b8aa9b6ec8f9612b902bb684e9 | |
parent | a0d605372a279d71abd29ed985b9a51e66e12170 (diff) |
drm: Fix PANEL_ORIENTATION_QUIRKS breaking the Kconfig DRM menuconfig
All Kconfig menu menu entries should have a depends on MENU_OPTION, the
menu stops after the first Kconfig entry without this depends on.
Since the PANEL_ORIENTATION_QUIRKS option is also used outside of DRM,
it deliberately does not have a depends on DRM, but this causes all
items after it to show as separate items rather then under the DRM
menuconfig.
This commit moves PANEL_ORIENTATION_QUIRKS to the end of the drm Kconfig
file, grouping it with DRM_LIB_RANDOM which also does not depend on DRM,
fixing the DRM menuconfig.
Fixes: 404d1a3edc38 ("drm: Add panel orientation quirks, v6.")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180117081032.6411-1-hdegoede@redhat.com
-rw-r--r-- | drivers/gpu/drm/Kconfig | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index d853989848d6..fbd37be9e882 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig | |||
@@ -27,10 +27,6 @@ config DRM_MIPI_DSI | |||
27 | bool | 27 | bool |
28 | depends on DRM | 28 | depends on DRM |
29 | 29 | ||
30 | # Separate option because drm_panel_orientation_quirks.c is shared with fbdev | ||
31 | config DRM_PANEL_ORIENTATION_QUIRKS | ||
32 | tristate | ||
33 | |||
34 | config DRM_DP_AUX_CHARDEV | 30 | config DRM_DP_AUX_CHARDEV |
35 | bool "DRM DP AUX Interface" | 31 | bool "DRM DP AUX Interface" |
36 | depends on DRM | 32 | depends on DRM |
@@ -367,6 +363,10 @@ config DRM_SAVAGE | |||
367 | 363 | ||
368 | endif # DRM_LEGACY | 364 | endif # DRM_LEGACY |
369 | 365 | ||
366 | # Separate option because drm_panel_orientation_quirks.c is shared with fbdev | ||
367 | config DRM_PANEL_ORIENTATION_QUIRKS | ||
368 | tristate | ||
369 | |||
370 | config DRM_LIB_RANDOM | 370 | config DRM_LIB_RANDOM |
371 | bool | 371 | bool |
372 | default n | 372 | default n |