diff options
author | Paul Gortmaker <paul.gortmaker@windriver.com> | 2016-02-14 18:09:53 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2016-02-16 03:11:08 -0500 |
commit | 32ed42ad6c42d6e0e78914a25c216fbbd595e74d (patch) | |
tree | efdd2dbfcc42e5b86c34106f24dae444d37cc6c4 | |
parent | 7f5301b7e66a1fd096b5d10dbb0bb2a8832516b4 (diff) |
x86/platform: Make platform/intel-quark/imr_selftest.c explicitly non-modular
The Kconfig currently controlling compilation of this code is:
arch/x86/Kconfig.debug:config DEBUG_IMR_SELFTEST
arch/x86/Kconfig.debug: bool "Isolated Memory Region self test"
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.
Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.
Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Reviewed-by: Bryan O'Donoghue <pure.logic@nexus-software.ie>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1455491396-30977-3-git-send-email-paul.gortmaker@windriver.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r-- | arch/x86/platform/intel-quark/imr_selftest.c | 15 |
1 files changed, 2 insertions, 13 deletions
diff --git a/arch/x86/platform/intel-quark/imr_selftest.c b/arch/x86/platform/intel-quark/imr_selftest.c index 278e4da4222f..0381343a0d3a 100644 --- a/arch/x86/platform/intel-quark/imr_selftest.c +++ b/arch/x86/platform/intel-quark/imr_selftest.c | |||
@@ -1,5 +1,5 @@ | |||
1 | /** | 1 | /** |
2 | * imr_selftest.c | 2 | * imr_selftest.c -- Intel Isolated Memory Region self-test driver |
3 | * | 3 | * |
4 | * Copyright(c) 2013 Intel Corporation. | 4 | * Copyright(c) 2013 Intel Corporation. |
5 | * Copyright(c) 2015 Bryan O'Donoghue <pure.logic@nexus-software.ie> | 5 | * Copyright(c) 2015 Bryan O'Donoghue <pure.logic@nexus-software.ie> |
@@ -15,7 +15,6 @@ | |||
15 | #include <asm/imr.h> | 15 | #include <asm/imr.h> |
16 | #include <linux/init.h> | 16 | #include <linux/init.h> |
17 | #include <linux/mm.h> | 17 | #include <linux/mm.h> |
18 | #include <linux/module.h> | ||
19 | #include <linux/types.h> | 18 | #include <linux/types.h> |
20 | 19 | ||
21 | #define SELFTEST KBUILD_MODNAME ": " | 20 | #define SELFTEST KBUILD_MODNAME ": " |
@@ -106,7 +105,6 @@ static const struct x86_cpu_id imr_ids[] __initconst = { | |||
106 | { X86_VENDOR_INTEL, 5, 9 }, /* Intel Quark SoC X1000. */ | 105 | { X86_VENDOR_INTEL, 5, 9 }, /* Intel Quark SoC X1000. */ |
107 | {} | 106 | {} |
108 | }; | 107 | }; |
109 | MODULE_DEVICE_TABLE(x86cpu, imr_ids); | ||
110 | 108 | ||
111 | /** | 109 | /** |
112 | * imr_self_test_init - entry point for IMR driver. | 110 | * imr_self_test_init - entry point for IMR driver. |
@@ -125,13 +123,4 @@ static int __init imr_self_test_init(void) | |||
125 | * | 123 | * |
126 | * return: | 124 | * return: |
127 | */ | 125 | */ |
128 | static void __exit imr_self_test_exit(void) | 126 | device_initcall(imr_self_test_init); |
129 | { | ||
130 | } | ||
131 | |||
132 | module_init(imr_self_test_init); | ||
133 | module_exit(imr_self_test_exit); | ||
134 | |||
135 | MODULE_AUTHOR("Bryan O'Donoghue <pure.logic@nexus-software.ie>"); | ||
136 | MODULE_DESCRIPTION("Intel Isolated Memory Region self-test driver"); | ||
137 | MODULE_LICENSE("Dual BSD/GPL"); | ||