diff options
author | Yuchung Cheng <ycheng@google.com> | 2019-01-08 21:12:24 -0500 |
---|---|---|
committer | Alexei Starovoitov <ast@kernel.org> | 2019-01-09 18:17:46 -0500 |
commit | 31aa6503a15ba00182ea6dbbf51afb63bf9e851d (patch) | |
tree | c178cabac27fe84159c2385fa85a2e282b048832 | |
parent | d972f3dce8d161e2142da0ab1ef25df00e2f21a9 (diff) |
bpf: correctly set initial window on active Fast Open sender
The existing BPF TCP initial congestion window (TCP_BPF_IW) does not
to work on (active) Fast Open sender. This is because it changes the
(initial) window only if data_segs_out is zero -- but data_segs_out
is also incremented on SYN-data. This patch fixes the issue by
proerly accounting for SYN-data additionally.
Fixes: fc7478103c84 ("bpf: Adds support for setting initial cwnd")
Signed-off-by: Yuchung Cheng <ycheng@google.com>
Reviewed-by: Neal Cardwell <ncardwell@google.com>
Acked-by: Lawrence Brakmo <brakmo@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
-rw-r--r-- | net/core/filter.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/filter.c b/net/core/filter.c index 447dd1bad31f..2b3b436ef545 100644 --- a/net/core/filter.c +++ b/net/core/filter.c | |||
@@ -4203,7 +4203,7 @@ BPF_CALL_5(bpf_setsockopt, struct bpf_sock_ops_kern *, bpf_sock, | |||
4203 | /* Only some options are supported */ | 4203 | /* Only some options are supported */ |
4204 | switch (optname) { | 4204 | switch (optname) { |
4205 | case TCP_BPF_IW: | 4205 | case TCP_BPF_IW: |
4206 | if (val <= 0 || tp->data_segs_out > 0) | 4206 | if (val <= 0 || tp->data_segs_out > tp->syn_data) |
4207 | ret = -EINVAL; | 4207 | ret = -EINVAL; |
4208 | else | 4208 | else |
4209 | tp->snd_cwnd = val; | 4209 | tp->snd_cwnd = val; |