diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-03-02 05:10:27 -0500 |
---|---|---|
committer | Joerg Roedel <jroedel@suse.de> | 2016-03-02 09:49:21 -0500 |
commit | 3189e4905c2d08d6618d79af2c486f530bbfb3b4 (patch) | |
tree | acf8cca54769ccff453bbce6494b07520b9fecf6 | |
parent | 0b6c0ad3cfe6bc914af3ae595c9729e38f11a024 (diff) |
iommu/mediatek: Check for NULL instead of IS_ERR()
of_platform_device_create() returns NULL on error, it never returns
error pointers.
Fixes: 0df4fabe208d ('iommu/mediatek: Add mt8173 IOMMU driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
-rw-r--r-- | drivers/iommu/mtk_iommu.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c index 4b9ae64c2fc3..929a66a81b2b 100644 --- a/drivers/iommu/mtk_iommu.c +++ b/drivers/iommu/mtk_iommu.c | |||
@@ -627,7 +627,7 @@ static int mtk_iommu_probe(struct platform_device *pdev) | |||
627 | plarbdev = of_platform_device_create( | 627 | plarbdev = of_platform_device_create( |
628 | larbnode, NULL, | 628 | larbnode, NULL, |
629 | platform_bus_type.dev_root); | 629 | platform_bus_type.dev_root); |
630 | if (IS_ERR(plarbdev)) | 630 | if (!plarbdev) |
631 | return -EPROBE_DEFER; | 631 | return -EPROBE_DEFER; |
632 | } | 632 | } |
633 | data->smi_imu.larb_imu[i].dev = &plarbdev->dev; | 633 | data->smi_imu.larb_imu[i].dev = &plarbdev->dev; |
@@ -720,8 +720,8 @@ static int mtk_iommu_init_fn(struct device_node *np) | |||
720 | struct platform_device *pdev; | 720 | struct platform_device *pdev; |
721 | 721 | ||
722 | pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root); | 722 | pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root); |
723 | if (IS_ERR(pdev)) | 723 | if (!pdev) |
724 | return PTR_ERR(pdev); | 724 | return -ENOMEM; |
725 | 725 | ||
726 | ret = platform_driver_register(&mtk_iommu_driver); | 726 | ret = platform_driver_register(&mtk_iommu_driver); |
727 | if (ret) { | 727 | if (ret) { |