diff options
author | Rex Zhu <Rex.Zhu@amd.com> | 2018-09-29 02:52:31 -0400 |
---|---|---|
committer | Alex Deucher <alexander.deucher@amd.com> | 2018-10-09 18:05:25 -0400 |
commit | 3023015f791639838ec5d80e5c14851238a1a7d9 (patch) | |
tree | a66b1bb33518c815bec204372650d5989f094db8 | |
parent | e5081e30eba1493f098b6e65e22124e36b2de743 (diff) |
drm/amd/pp: Fix memory leak on CI/AI
On CI/AI, fw was not loaded by smu, but
smu's fw still need to be released
when driver fini.
Reviewed-by: Evan Quan <evan.quan@amd.com>
Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r-- | drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c index 9d8fa2e39bad..e51d961a94b2 100644 --- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c +++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c | |||
@@ -109,11 +109,11 @@ static int pp_sw_fini(void *handle) | |||
109 | 109 | ||
110 | hwmgr_sw_fini(hwmgr); | 110 | hwmgr_sw_fini(hwmgr); |
111 | 111 | ||
112 | if (adev->firmware.load_type == AMDGPU_FW_LOAD_SMU) { | 112 | if (adev->firmware.load_type == AMDGPU_FW_LOAD_SMU) |
113 | release_firmware(adev->pm.fw); | ||
114 | adev->pm.fw = NULL; | ||
115 | amdgpu_ucode_fini_bo(adev); | 113 | amdgpu_ucode_fini_bo(adev); |
116 | } | 114 | |
115 | release_firmware(adev->pm.fw); | ||
116 | adev->pm.fw = NULL; | ||
117 | 117 | ||
118 | return 0; | 118 | return 0; |
119 | } | 119 | } |