aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTrond Myklebust <trondmy@gmail.com>2018-09-05 14:07:13 -0400
committerAnna Schumaker <Anna.Schumaker@Netapp.com>2018-09-14 16:24:08 -0400
commit2edaead69e7573f35e8d5dc20938e41eacc21b35 (patch)
treed4fae87639f1e646c9f11adafe9233b6d5549b68
parentd03360aaf5ccac49581960bd736258c62972b88b (diff)
NFSv4: Fix a tracepoint Oops in initiate_file_draining()
Now that the value of 'ino' can be NULL or an ERR_PTR(), we need to change the test in the tracepoint. Fixes: ce5624f7e6675 ("NFSv4: Return NFS4ERR_DELAY when a layout fails...") Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> Cc: stable@vger.kernel.org # v4.17+ Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
-rw-r--r--fs/nfs/nfs4trace.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/nfs4trace.h b/fs/nfs/nfs4trace.h
index 708342f4692f..b1483b303e0b 100644
--- a/fs/nfs/nfs4trace.h
+++ b/fs/nfs/nfs4trace.h
@@ -1137,7 +1137,7 @@ DECLARE_EVENT_CLASS(nfs4_inode_callback_event,
1137 TP_fast_assign( 1137 TP_fast_assign(
1138 __entry->error = error; 1138 __entry->error = error;
1139 __entry->fhandle = nfs_fhandle_hash(fhandle); 1139 __entry->fhandle = nfs_fhandle_hash(fhandle);
1140 if (inode != NULL) { 1140 if (!IS_ERR_OR_NULL(inode)) {
1141 __entry->fileid = NFS_FILEID(inode); 1141 __entry->fileid = NFS_FILEID(inode);
1142 __entry->dev = inode->i_sb->s_dev; 1142 __entry->dev = inode->i_sb->s_dev;
1143 } else { 1143 } else {