diff options
author | Alex Deucher <alexander.deucher@amd.com> | 2014-09-12 18:00:53 -0400 |
---|---|---|
committer | Alex Deucher <alexander.deucher@amd.com> | 2014-09-18 19:22:09 -0400 |
commit | 2e97140dd58cab8772bf77d73eabda213e45202d (patch) | |
tree | 8658adf9a7fec7bfa0df94e7d912c02c3f3af302 | |
parent | 766a53d059d1500c9755c8af017bd411bd8f1b20 (diff) |
drm/radeon/px: fix module unload
Use the new vga_switcheroo_fini_domain_pm_ops function
to unregister the pm ops.
Based on a patch from:
Pali Rohár <pali.rohar@gmail.com>
bug:
https://bugzilla.kernel.org/show_bug.cgi?id=84431
Reviewed-by: Ben Skeggs <bskeggs@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
Cc: Ben Skeggs <bskeggs@redhat.com>
-rw-r--r-- | drivers/gpu/drm/radeon/radeon_device.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c index 6a219bcee66d..75223dd3a8a3 100644 --- a/drivers/gpu/drm/radeon/radeon_device.c +++ b/drivers/gpu/drm/radeon/radeon_device.c | |||
@@ -1393,7 +1393,7 @@ int radeon_device_init(struct radeon_device *rdev, | |||
1393 | 1393 | ||
1394 | r = radeon_init(rdev); | 1394 | r = radeon_init(rdev); |
1395 | if (r) | 1395 | if (r) |
1396 | return r; | 1396 | goto failed; |
1397 | 1397 | ||
1398 | r = radeon_ib_ring_tests(rdev); | 1398 | r = radeon_ib_ring_tests(rdev); |
1399 | if (r) | 1399 | if (r) |
@@ -1413,7 +1413,7 @@ int radeon_device_init(struct radeon_device *rdev, | |||
1413 | radeon_agp_disable(rdev); | 1413 | radeon_agp_disable(rdev); |
1414 | r = radeon_init(rdev); | 1414 | r = radeon_init(rdev); |
1415 | if (r) | 1415 | if (r) |
1416 | return r; | 1416 | goto failed; |
1417 | } | 1417 | } |
1418 | 1418 | ||
1419 | if ((radeon_testing & 1)) { | 1419 | if ((radeon_testing & 1)) { |
@@ -1435,6 +1435,11 @@ int radeon_device_init(struct radeon_device *rdev, | |||
1435 | DRM_INFO("radeon: acceleration disabled, skipping benchmarks\n"); | 1435 | DRM_INFO("radeon: acceleration disabled, skipping benchmarks\n"); |
1436 | } | 1436 | } |
1437 | return 0; | 1437 | return 0; |
1438 | |||
1439 | failed: | ||
1440 | if (runtime) | ||
1441 | vga_switcheroo_fini_domain_pm_ops(rdev->dev); | ||
1442 | return r; | ||
1438 | } | 1443 | } |
1439 | 1444 | ||
1440 | static void radeon_debugfs_remove_files(struct radeon_device *rdev); | 1445 | static void radeon_debugfs_remove_files(struct radeon_device *rdev); |
@@ -1455,6 +1460,8 @@ void radeon_device_fini(struct radeon_device *rdev) | |||
1455 | radeon_bo_evict_vram(rdev); | 1460 | radeon_bo_evict_vram(rdev); |
1456 | radeon_fini(rdev); | 1461 | radeon_fini(rdev); |
1457 | vga_switcheroo_unregister_client(rdev->pdev); | 1462 | vga_switcheroo_unregister_client(rdev->pdev); |
1463 | if (rdev->flags & RADEON_IS_PX) | ||
1464 | vga_switcheroo_fini_domain_pm_ops(rdev->dev); | ||
1458 | vga_client_register(rdev->pdev, NULL, NULL, NULL); | 1465 | vga_client_register(rdev->pdev, NULL, NULL, NULL); |
1459 | if (rdev->rio_mem) | 1466 | if (rdev->rio_mem) |
1460 | pci_iounmap(rdev->pdev, rdev->rio_mem); | 1467 | pci_iounmap(rdev->pdev, rdev->rio_mem); |