diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2016-06-01 17:40:36 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2016-06-02 10:25:20 -0400 |
commit | 2e7a5701c9b2ee47089677ed5fbbc397b3bf3dec (patch) | |
tree | b3a81e13ef980a2c2233afe9e3d63336426b3981 | |
parent | 8e01550ec8fc6ae60dfb059f3a7e993c709bd309 (diff) |
drm/doc: Appease sphinx
Mostly this is unexpected indents. But really it's just a
demonstration for my patch, all these issues have been found&fixed
using the correct source file and line number support I just added.
All line numbers have been perfectly accurate.
One issue looked a bit fishy in intel_lrc.c, where I don't quite grok
what sphinx is unhappy about. But since that file looks like it has
never seen a proper kernel-doc parser I figured better to fix in a
separate path.
v2: Use fancy new &drm_device->struct_mutex linking (Jani).
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: linux-doc@vger.kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
-rw-r--r-- | drivers/gpu/drm/drm_atomic_helper.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/drm_crtc.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/drm_gem.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/drm_modes.c | 1 | ||||
-rw-r--r-- | drivers/gpu/drm/drm_plane_helper.c | 10 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_dp.c | 16 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_fbc.c | 3 |
7 files changed, 20 insertions, 16 deletions
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index d62899cb3403..a1d9c24c9428 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c | |||
@@ -2399,7 +2399,7 @@ EXPORT_SYMBOL(drm_atomic_helper_page_flip); | |||
2399 | * This is the main helper function provided by the atomic helper framework for | 2399 | * This is the main helper function provided by the atomic helper framework for |
2400 | * implementing the legacy DPMS connector interface. It computes the new desired | 2400 | * implementing the legacy DPMS connector interface. It computes the new desired |
2401 | * ->active state for the corresponding CRTC (if the connector is enabled) and | 2401 | * ->active state for the corresponding CRTC (if the connector is enabled) and |
2402 | * updates it. | 2402 | * updates it. |
2403 | * | 2403 | * |
2404 | * Returns: | 2404 | * Returns: |
2405 | * Returns 0 on success, negative errno numbers on failure. | 2405 | * Returns 0 on success, negative errno numbers on failure. |
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 37427b2bb9fc..3cbf08b20413 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c | |||
@@ -535,7 +535,7 @@ EXPORT_SYMBOL(drm_framebuffer_unregister_private); | |||
535 | * | 535 | * |
536 | * Cleanup framebuffer. This function is intended to be used from the drivers | 536 | * Cleanup framebuffer. This function is intended to be used from the drivers |
537 | * ->destroy callback. It can also be used to clean up driver private | 537 | * ->destroy callback. It can also be used to clean up driver private |
538 | * framebuffers embedded into a larger structure. | 538 | * framebuffers embedded into a larger structure. |
539 | * | 539 | * |
540 | * Note that this function does not remove the fb from active usuage - if it is | 540 | * Note that this function does not remove the fb from active usuage - if it is |
541 | * still used anywhere, hilarity can ensue since userspace could call getfb on | 541 | * still used anywhere, hilarity can ensue since userspace could call getfb on |
diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 32156060b9c9..5c19dde1cd31 100644 --- a/drivers/gpu/drm/drm_gem.c +++ b/drivers/gpu/drm/drm_gem.c | |||
@@ -787,7 +787,7 @@ EXPORT_SYMBOL(drm_gem_object_release); | |||
787 | * @kref: kref of the object to free | 787 | * @kref: kref of the object to free |
788 | * | 788 | * |
789 | * Called after the last reference to the object has been lost. | 789 | * Called after the last reference to the object has been lost. |
790 | * Must be called holding struct_ mutex | 790 | * Must be called holding &drm_device->struct_mutex. |
791 | * | 791 | * |
792 | * Frees the object | 792 | * Frees the object |
793 | */ | 793 | */ |
diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c index 7def3d58da18..adf73f8516af 100644 --- a/drivers/gpu/drm/drm_modes.c +++ b/drivers/gpu/drm/drm_modes.c | |||
@@ -544,6 +544,7 @@ EXPORT_SYMBOL(drm_gtf_mode_complex); | |||
544 | * | 544 | * |
545 | * This function is to create the modeline based on the GTF algorithm. | 545 | * This function is to create the modeline based on the GTF algorithm. |
546 | * Generalized Timing Formula is derived from: | 546 | * Generalized Timing Formula is derived from: |
547 | * | ||
547 | * GTF Spreadsheet by Andy Morrish (1/5/97) | 548 | * GTF Spreadsheet by Andy Morrish (1/5/97) |
548 | * available at http://www.vesa.org | 549 | * available at http://www.vesa.org |
549 | * | 550 | * |
diff --git a/drivers/gpu/drm/drm_plane_helper.c b/drivers/gpu/drm/drm_plane_helper.c index 369d2898ff9e..fc51306fe365 100644 --- a/drivers/gpu/drm/drm_plane_helper.c +++ b/drivers/gpu/drm/drm_plane_helper.c | |||
@@ -219,10 +219,12 @@ EXPORT_SYMBOL(drm_plane_helper_check_update); | |||
219 | * | 219 | * |
220 | * Note that we make some assumptions about hardware limitations that may not be | 220 | * Note that we make some assumptions about hardware limitations that may not be |
221 | * true for all hardware -- | 221 | * true for all hardware -- |
222 | * 1) Primary plane cannot be repositioned. | 222 | * |
223 | * 2) Primary plane cannot be scaled. | 223 | * 1. Primary plane cannot be repositioned. |
224 | * 3) Primary plane must cover the entire CRTC. | 224 | * 2. Primary plane cannot be scaled. |
225 | * 4) Subpixel positioning is not supported. | 225 | * 3. Primary plane must cover the entire CRTC. |
226 | * 4. Subpixel positioning is not supported. | ||
227 | * | ||
226 | * Drivers for hardware that don't have these restrictions can provide their | 228 | * Drivers for hardware that don't have these restrictions can provide their |
227 | * own implementation rather than using this helper. | 229 | * own implementation rather than using this helper. |
228 | * | 230 | * |
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index cccf9bc7c7d6..2834ca5216b2 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c | |||
@@ -5214,14 +5214,14 @@ void intel_edp_drrs_flush(struct drm_device *dev, | |||
5214 | * | 5214 | * |
5215 | * DRRS saves power by switching to low RR based on usage scenarios. | 5215 | * DRRS saves power by switching to low RR based on usage scenarios. |
5216 | * | 5216 | * |
5217 | * eDP DRRS:- | 5217 | * The implementation is based on frontbuffer tracking implementation. When |
5218 | * The implementation is based on frontbuffer tracking implementation. | 5218 | * there is a disturbance on the screen triggered by user activity or a periodic |
5219 | * When there is a disturbance on the screen triggered by user activity or a | 5219 | * system activity, DRRS is disabled (RR is changed to high RR). When there is |
5220 | * periodic system activity, DRRS is disabled (RR is changed to high RR). | 5220 | * no movement on screen, after a timeout of 1 second, a switch to low RR is |
5221 | * When there is no movement on screen, after a timeout of 1 second, a switch | 5221 | * made. |
5222 | * to low RR is made. | 5222 | * |
5223 | * For integration with frontbuffer tracking code, | 5223 | * For integration with frontbuffer tracking code, intel_edp_drrs_invalidate() |
5224 | * intel_edp_drrs_invalidate() and intel_edp_drrs_flush() are called. | 5224 | * and intel_edp_drrs_flush() are called. |
5225 | * | 5225 | * |
5226 | * DRRS can be further extended to support other internal panels and also | 5226 | * DRRS can be further extended to support other internal panels and also |
5227 | * the scenario of video playback wherein RR is set based on the rate | 5227 | * the scenario of video playback wherein RR is set based on the rate |
diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c index 0dea5fbcd8aa..45ee07b888a0 100644 --- a/drivers/gpu/drm/i915/intel_fbc.c +++ b/drivers/gpu/drm/i915/intel_fbc.c | |||
@@ -374,8 +374,9 @@ static void intel_fbc_hw_deactivate(struct drm_i915_private *dev_priv) | |||
374 | * @dev_priv: i915 device instance | 374 | * @dev_priv: i915 device instance |
375 | * | 375 | * |
376 | * This function is used to verify the current state of FBC. | 376 | * This function is used to verify the current state of FBC. |
377 | * | ||
377 | * FIXME: This should be tracked in the plane config eventually | 378 | * FIXME: This should be tracked in the plane config eventually |
378 | * instead of queried at runtime for most callers. | 379 | * instead of queried at runtime for most callers. |
379 | */ | 380 | */ |
380 | bool intel_fbc_is_active(struct drm_i915_private *dev_priv) | 381 | bool intel_fbc_is_active(struct drm_i915_private *dev_priv) |
381 | { | 382 | { |