aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2018-05-16 18:29:56 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2018-08-03 16:03:31 -0400
commit2e5afe54e0cd6fce79b51ca547caf08a990ad56d (patch)
treee1216c8896876b5f8e5e8a2dd990eacbb3236956
parent5c1a68a358f94b9ac2e33183327bc04f207feed2 (diff)
ext2: make sure that partially set up inodes won't be returned by ext2_iget()
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r--fs/ext2/ialloc.c3
-rw-r--r--fs/ext2/namei.c9
2 files changed, 4 insertions, 8 deletions
diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
index 6484199b35d1..5c3d7b7e4975 100644
--- a/fs/ext2/ialloc.c
+++ b/fs/ext2/ialloc.c
@@ -611,8 +611,7 @@ fail_drop:
611 dquot_drop(inode); 611 dquot_drop(inode);
612 inode->i_flags |= S_NOQUOTA; 612 inode->i_flags |= S_NOQUOTA;
613 clear_nlink(inode); 613 clear_nlink(inode);
614 unlock_new_inode(inode); 614 discard_new_inode(inode);
615 iput(inode);
616 return ERR_PTR(err); 615 return ERR_PTR(err);
617 616
618fail: 617fail:
diff --git a/fs/ext2/namei.c b/fs/ext2/namei.c
index 152453a91877..0c26dcc5d850 100644
--- a/fs/ext2/namei.c
+++ b/fs/ext2/namei.c
@@ -45,8 +45,7 @@ static inline int ext2_add_nondir(struct dentry *dentry, struct inode *inode)
45 return 0; 45 return 0;
46 } 46 }
47 inode_dec_link_count(inode); 47 inode_dec_link_count(inode);
48 unlock_new_inode(inode); 48 discard_new_inode(inode);
49 iput(inode);
50 return err; 49 return err;
51} 50}
52 51
@@ -192,8 +191,7 @@ out:
192 191
193out_fail: 192out_fail:
194 inode_dec_link_count(inode); 193 inode_dec_link_count(inode);
195 unlock_new_inode(inode); 194 discard_new_inode(inode);
196 iput (inode);
197 goto out; 195 goto out;
198} 196}
199 197
@@ -261,8 +259,7 @@ out:
261out_fail: 259out_fail:
262 inode_dec_link_count(inode); 260 inode_dec_link_count(inode);
263 inode_dec_link_count(inode); 261 inode_dec_link_count(inode);
264 unlock_new_inode(inode); 262 discard_new_inode(inode);
265 iput(inode);
266out_dir: 263out_dir:
267 inode_dec_link_count(dir); 264 inode_dec_link_count(dir);
268 goto out; 265 goto out;