diff options
author | Baoyou Xie <baoyou.xie@linaro.org> | 2016-09-01 07:15:35 -0400 |
---|---|---|
committer | Alex Williamson <alex.williamson@redhat.com> | 2016-09-13 18:11:37 -0400 |
commit | 2e06285655b59362847b610a7cfad204fee9640b (patch) | |
tree | 5ca738d21f4710ed438129ef6da1761356373e6d | |
parent | 8138dabbab269d9d6ba2ffa17aad03aff22cfdb6 (diff) |
vfio: platform: mark symbols static where possible
We get a few warnings when building kernel with W=1:
drivers/vfio/platform/vfio_platform_common.c:76:5: warning: no previous prototype for 'vfio_platform_acpi_call_reset' [-Wmissing-prototypes]
drivers/vfio/platform/vfio_platform_common.c:98:6: warning: no previous prototype for 'vfio_platform_acpi_has_reset' [-Wmissing-prototypes]
drivers/vfio/platform/vfio_platform_common.c:640:5: warning: no previous prototype for 'vfio_platform_of_probe' [-Wmissing-prototypes]
drivers/vfio/platform/reset/vfio_platform_amdxgbe.c:59:5: warning: no previous prototype for 'vfio_platform_amdxgbe_reset' [-Wmissing-prototypes]
drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c:60:5: warning: no previous prototype for 'vfio_platform_calxedaxgmac_reset' [-Wmissing-prototypes]
....
In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
so this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Baptiste Reynal <b.reynal@virtualopensystems.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
-rw-r--r-- | drivers/vfio/platform/reset/vfio_platform_amdxgbe.c | 2 | ||||
-rw-r--r-- | drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c | 2 | ||||
-rw-r--r-- | drivers/vfio/platform/vfio_platform_common.c | 6 |
3 files changed, 5 insertions, 5 deletions
diff --git a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c index d4030d0c38e9..bcd419cfd79c 100644 --- a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c +++ b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c | |||
@@ -56,7 +56,7 @@ static void xmdio_write(void *ioaddr, unsigned int mmd, | |||
56 | iowrite32(value, ioaddr + ((mmd_address & 0xff) << 2)); | 56 | iowrite32(value, ioaddr + ((mmd_address & 0xff) << 2)); |
57 | } | 57 | } |
58 | 58 | ||
59 | int vfio_platform_amdxgbe_reset(struct vfio_platform_device *vdev) | 59 | static int vfio_platform_amdxgbe_reset(struct vfio_platform_device *vdev) |
60 | { | 60 | { |
61 | struct vfio_platform_region *xgmac_regs = &vdev->regions[0]; | 61 | struct vfio_platform_region *xgmac_regs = &vdev->regions[0]; |
62 | struct vfio_platform_region *xpcs_regs = &vdev->regions[1]; | 62 | struct vfio_platform_region *xpcs_regs = &vdev->regions[1]; |
diff --git a/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c b/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c index e3d3d948e661..49e5df6e8f29 100644 --- a/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c +++ b/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c | |||
@@ -57,7 +57,7 @@ static inline void xgmac_mac_disable(void __iomem *ioaddr) | |||
57 | writel(value, ioaddr + XGMAC_CONTROL); | 57 | writel(value, ioaddr + XGMAC_CONTROL); |
58 | } | 58 | } |
59 | 59 | ||
60 | int vfio_platform_calxedaxgmac_reset(struct vfio_platform_device *vdev) | 60 | static int vfio_platform_calxedaxgmac_reset(struct vfio_platform_device *vdev) |
61 | { | 61 | { |
62 | struct vfio_platform_region *reg = &vdev->regions[0]; | 62 | struct vfio_platform_region *reg = &vdev->regions[0]; |
63 | 63 | ||
diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c index 1cf2d462b53d..d78142830754 100644 --- a/drivers/vfio/platform/vfio_platform_common.c +++ b/drivers/vfio/platform/vfio_platform_common.c | |||
@@ -73,7 +73,7 @@ static int vfio_platform_acpi_probe(struct vfio_platform_device *vdev, | |||
73 | return WARN_ON(!vdev->acpihid) ? -EINVAL : 0; | 73 | return WARN_ON(!vdev->acpihid) ? -EINVAL : 0; |
74 | } | 74 | } |
75 | 75 | ||
76 | int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev, | 76 | static int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev, |
77 | const char **extra_dbg) | 77 | const char **extra_dbg) |
78 | { | 78 | { |
79 | #ifdef CONFIG_ACPI | 79 | #ifdef CONFIG_ACPI |
@@ -95,7 +95,7 @@ int vfio_platform_acpi_call_reset(struct vfio_platform_device *vdev, | |||
95 | #endif | 95 | #endif |
96 | } | 96 | } |
97 | 97 | ||
98 | bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev) | 98 | static bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev) |
99 | { | 99 | { |
100 | #ifdef CONFIG_ACPI | 100 | #ifdef CONFIG_ACPI |
101 | struct device *dev = vdev->device; | 101 | struct device *dev = vdev->device; |
@@ -637,7 +637,7 @@ static const struct vfio_device_ops vfio_platform_ops = { | |||
637 | .mmap = vfio_platform_mmap, | 637 | .mmap = vfio_platform_mmap, |
638 | }; | 638 | }; |
639 | 639 | ||
640 | int vfio_platform_of_probe(struct vfio_platform_device *vdev, | 640 | static int vfio_platform_of_probe(struct vfio_platform_device *vdev, |
641 | struct device *dev) | 641 | struct device *dev) |
642 | { | 642 | { |
643 | int ret; | 643 | int ret; |