aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJames Simmons <jsimmons@infradead.org>2016-03-11 20:29:51 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-03-12 01:26:02 -0500
commit2df122bdebaba1daad3a8087b89a5e3456474538 (patch)
tree0bf5690d0bdee0de4b53e4feb43fbc853afc9740
parentd7fc52bdf2e09e21daab2a8a4986b6c09260d3ae (diff)
staging: lustre: fix aligments in lnet selftest
Some aligment issues were not caught by checkpatch. We address them here. Some of the alignment issues caused greater than 80 character checkpatch issues. Some changes were done to just make the code more readable and to match our production code. Signed-off-by: James Simmons <jsimmons@infradead.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/lustre/lnet/selftest/conctl.c10
-rw-r--r--drivers/staging/lustre/lnet/selftest/conrpc.c11
-rw-r--r--drivers/staging/lustre/lnet/selftest/console.c7
-rw-r--r--drivers/staging/lustre/lnet/selftest/framework.c5
-rw-r--r--drivers/staging/lustre/lnet/selftest/module.c3
5 files changed, 17 insertions, 19 deletions
diff --git a/drivers/staging/lustre/lnet/selftest/conctl.c b/drivers/staging/lustre/lnet/selftest/conctl.c
index 872df72a221f..5c7cb72eac9a 100644
--- a/drivers/staging/lustre/lnet/selftest/conctl.c
+++ b/drivers/staging/lustre/lnet/selftest/conctl.c
@@ -278,8 +278,7 @@ lst_group_update_ioctl(lstio_group_update_args_t *args)
278 if (!name) 278 if (!name)
279 return -ENOMEM; 279 return -ENOMEM;
280 280
281 if (copy_from_user(name, 281 if (copy_from_user(name, args->lstio_grp_namep,
282 args->lstio_grp_namep,
283 args->lstio_grp_nmlen)) { 282 args->lstio_grp_nmlen)) {
284 LIBCFS_FREE(name, args->lstio_grp_nmlen + 1); 283 LIBCFS_FREE(name, args->lstio_grp_nmlen + 1);
285 return -EFAULT; 284 return -EFAULT;
@@ -375,8 +374,8 @@ lst_group_list_ioctl(lstio_group_list_args_t *args)
375 return -EINVAL; 374 return -EINVAL;
376 375
377 return lstcon_group_list(args->lstio_grp_idx, 376 return lstcon_group_list(args->lstio_grp_idx,
378 args->lstio_grp_nmlen, 377 args->lstio_grp_nmlen,
379 args->lstio_grp_namep); 378 args->lstio_grp_namep);
380} 379}
381 380
382static int 381static int
@@ -743,7 +742,8 @@ static int lst_test_add_ioctl(lstio_test_args_t *args)
743 /* have parameter, check if parameter length is valid */ 742 /* have parameter, check if parameter length is valid */
744 if (args->lstio_tes_param && 743 if (args->lstio_tes_param &&
745 (args->lstio_tes_param_len <= 0 || 744 (args->lstio_tes_param_len <= 0 ||
746 args->lstio_tes_param_len > PAGE_CACHE_SIZE - sizeof(lstcon_test_t))) 745 args->lstio_tes_param_len >
746 PAGE_CACHE_SIZE - sizeof(lstcon_test_t)))
747 return -EINVAL; 747 return -EINVAL;
748 748
749 LIBCFS_ALLOC(batch_name, args->lstio_tes_bat_nmlen + 1); 749 LIBCFS_ALLOC(batch_name, args->lstio_tes_bat_nmlen + 1);
diff --git a/drivers/staging/lustre/lnet/selftest/conrpc.c b/drivers/staging/lustre/lnet/selftest/conrpc.c
index dc454ca8cd90..bcd78888f9cc 100644
--- a/drivers/staging/lustre/lnet/selftest/conrpc.c
+++ b/drivers/staging/lustre/lnet/selftest/conrpc.c
@@ -235,8 +235,8 @@ lstcon_rpc_trans_name(int transop)
235} 235}
236 236
237int 237int
238lstcon_rpc_trans_prep(struct list_head *translist, 238lstcon_rpc_trans_prep(struct list_head *translist, int transop,
239 int transop, lstcon_rpc_trans_t **transpp) 239 lstcon_rpc_trans_t **transpp)
240{ 240{
241 lstcon_rpc_trans_t *trans; 241 lstcon_rpc_trans_t *trans;
242 242
@@ -547,8 +547,7 @@ lstcon_rpc_trans_destroy(lstcon_rpc_trans_t *trans)
547 lstcon_rpc_t *tmp; 547 lstcon_rpc_t *tmp;
548 int count = 0; 548 int count = 0;
549 549
550 list_for_each_entry_safe(crpc, tmp, &trans->tas_rpcs_list, 550 list_for_each_entry_safe(crpc, tmp, &trans->tas_rpcs_list, crp_link) {
551 crp_link) {
552 rpc = crpc->crp_rpc; 551 rpc = crpc->crp_rpc;
553 552
554 spin_lock(&rpc->crpc_lock); 553 spin_lock(&rpc->crpc_lock);
@@ -668,8 +667,8 @@ lstcon_batrpc_prep(lstcon_node_t *nd, int transop, unsigned feats,
668 brq->bar_bid = tsb->tsb_id; 667 brq->bar_bid = tsb->tsb_id;
669 brq->bar_testidx = tsb->tsb_index; 668 brq->bar_testidx = tsb->tsb_index;
670 brq->bar_opc = transop == LST_TRANS_TSBRUN ? SRPC_BATCH_OPC_RUN : 669 brq->bar_opc = transop == LST_TRANS_TSBRUN ? SRPC_BATCH_OPC_RUN :
671 (transop == LST_TRANS_TSBSTOP ? SRPC_BATCH_OPC_STOP : 670 (transop == LST_TRANS_TSBSTOP ? SRPC_BATCH_OPC_STOP :
672 SRPC_BATCH_OPC_QUERY); 671 SRPC_BATCH_OPC_QUERY);
673 672
674 if (transop != LST_TRANS_TSBRUN && 673 if (transop != LST_TRANS_TSBRUN &&
675 transop != LST_TRANS_TSBSTOP) 674 transop != LST_TRANS_TSBSTOP)
diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c
index 6017f213b4d7..1a923ea3a755 100644
--- a/drivers/staging/lustre/lnet/selftest/console.c
+++ b/drivers/staging/lustre/lnet/selftest/console.c
@@ -76,7 +76,8 @@ lstcon_node_find(lnet_process_id_t id, lstcon_node_t **ndpp, int create)
76 76
77 LASSERT(id.nid != LNET_NID_ANY); 77 LASSERT(id.nid != LNET_NID_ANY);
78 78
79 list_for_each_entry(ndl, &console_session.ses_ndl_hash[idx], ndl_hlink) { 79 list_for_each_entry(ndl, &console_session.ses_ndl_hash[idx],
80 ndl_hlink) {
80 if (ndl->ndl_node->nd_id.nid != id.nid || 81 if (ndl->ndl_node->nd_id.nid != id.nid ||
81 ndl->ndl_node->nd_id.pid != id.pid) 82 ndl->ndl_node->nd_id.pid != id.pid)
82 continue; 83 continue;
@@ -316,7 +317,7 @@ lstcon_group_ndlink_move(lstcon_group_t *old,
316 lstcon_group_t *new, lstcon_ndlink_t *ndl) 317 lstcon_group_t *new, lstcon_ndlink_t *ndl)
317{ 318{
318 unsigned int idx = LNET_NIDADDR(ndl->ndl_node->nd_id.nid) % 319 unsigned int idx = LNET_NIDADDR(ndl->ndl_node->nd_id.nid) %
319 LST_NODE_HASHSIZE; 320 LST_NODE_HASHSIZE;
320 321
321 list_del(&ndl->ndl_hlink); 322 list_del(&ndl->ndl_hlink);
322 list_del(&ndl->ndl_link); 323 list_del(&ndl->ndl_link);
@@ -918,7 +919,7 @@ lstcon_batch_list(int index, int len, char __user *name_up)
918 list_for_each_entry(bat, &console_session.ses_bat_list, bat_link) { 919 list_for_each_entry(bat, &console_session.ses_bat_list, bat_link) {
919 if (!index--) { 920 if (!index--) {
920 return copy_to_user(name_up, bat->bat_name, len) ? 921 return copy_to_user(name_up, bat->bat_name, len) ?
921 -EFAULT : 0; 922 -EFAULT : 0;
922 } 923 }
923 } 924 }
924 925
diff --git a/drivers/staging/lustre/lnet/selftest/framework.c b/drivers/staging/lustre/lnet/selftest/framework.c
index 55f92da02bc0..926c3970c498 100644
--- a/drivers/staging/lustre/lnet/selftest/framework.c
+++ b/drivers/staging/lustre/lnet/selftest/framework.c
@@ -406,7 +406,7 @@ sfw_make_session(srpc_mksn_reqst_t *request, srpc_mksn_reply_t *reply)
406{ 406{
407 sfw_session_t *sn = sfw_data.fw_session; 407 sfw_session_t *sn = sfw_data.fw_session;
408 srpc_msg_t *msg = container_of(request, srpc_msg_t, 408 srpc_msg_t *msg = container_of(request, srpc_msg_t,
409 msg_body.mksn_reqst); 409 msg_body.mksn_reqst);
410 int cplen = 0; 410 int cplen = 0;
411 411
412 if (request->mksn_sid.ses_nid == LNET_NID_ANY) { 412 if (request->mksn_sid.ses_nid == LNET_NID_ANY) {
@@ -1017,8 +1017,7 @@ sfw_run_batch(sfw_batch_t *tsb)
1017 tsu->tsu_loop = tsi->tsi_loop; 1017 tsu->tsu_loop = tsi->tsi_loop;
1018 wi = &tsu->tsu_worker; 1018 wi = &tsu->tsu_worker;
1019 swi_init_workitem(wi, tsu, sfw_run_test, 1019 swi_init_workitem(wi, tsu, sfw_run_test,
1020 lst_sched_test[\ 1020 lst_sched_test[lnet_cpt_of_nid(tsu->tsu_dest.nid)]);
1021 lnet_cpt_of_nid(tsu->tsu_dest.nid)]);
1022 swi_schedule_workitem(wi); 1021 swi_schedule_workitem(wi);
1023 } 1022 }
1024 } 1023 }
diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre/lnet/selftest/module.c
index 1e858e9121cc..cc046b1d4d0a 100644
--- a/drivers/staging/lustre/lnet/selftest/module.c
+++ b/drivers/staging/lustre/lnet/selftest/module.c
@@ -116,8 +116,7 @@ lnet_selftest_init(void)
116 rc = cfs_wi_sched_create("lst_t", lnet_cpt_table(), i, 116 rc = cfs_wi_sched_create("lst_t", lnet_cpt_table(), i,
117 nthrs, &lst_sched_test[i]); 117 nthrs, &lst_sched_test[i]);
118 if (rc) { 118 if (rc) {
119 CERROR("Failed to create CPT affinity WI scheduler %d for LST\n", 119 CERROR("Failed to create CPT affinity WI scheduler %d for LST\n", i);
120 i);
121 goto error; 120 goto error;
122 } 121 }
123 } 122 }