scsi: qedi: Fix return code in qedi_ep_connect()

We shouldn't be writing over the "ret" variable.  It means we return
ERR_PTR(0) which is NULL and it results in a NULL dereference in the
caller.

Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscsi.c
index 80edd28b635f..37da9a8b43b1 100644
--- a/drivers/scsi/qedi/qedi_iscsi.c
+++ b/drivers/scsi/qedi/qedi_iscsi.c
@@ -824,7 +824,7 @@ qedi_ep_connect(struct Scsi_Host *shost, struct sockaddr *dst_addr,
         u32 iscsi_cid = QEDI_CID_RESERVED;
         u16 len = 0;
         char *buf = NULL;
-        int ret;
+        int ret, tmp;
 
         if (!shost) {
                 ret = -ENXIO;
@@ -940,10 +940,10 @@ qedi_ep_connect(struct Scsi_Host *shost, struct sockaddr *dst_addr,
 
 ep_rel_conn:
         qedi->ep_tbl[iscsi_cid] = NULL;
-        ret = qedi_ops->release_conn(qedi->cdev, qedi_ep->handle);
-        if (ret)
+        tmp = qedi_ops->release_conn(qedi->cdev, qedi_ep->handle);
+        if (tmp)
                 QEDI_WARN(&qedi->dbg_ctx, "release_conn returned %d\n",
-                          ret);
+                          tmp);
 ep_free_sq:
         qedi_free_sq(qedi, qedi_ep);
 ep_conn_exit: