aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArend Van Spriel <arend.vanspriel@broadcom.com>2016-12-09 06:34:14 -0500
committerKalle Valo <kvalo@codeaurora.org>2016-12-20 09:09:04 -0500
commit2b66325d5ea7c2a39ac69ed83b6979afe480d81a (patch)
tree383a11f0b7fedb157791c069189967f659a7755d
parentcb853da3a368c40300a0e940f86be582037bb082 (diff)
brcmfmac: fix uninitialized field in scheduled scan ssid configuration
The scheduled scan ssid configuration in firmware has a flags field that was not initialized resulting in unexpected behaviour. Fixes: e3bdb7cc0300 ("brcmfmac: fix handling ssids in .sched_scan_start() callback") Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com> Reviewed-by: Franky Lin <franky.lin@broadcom.com> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
-rw-r--r--drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c
index f273cab0da10..9a25e79a46cf 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c
@@ -137,6 +137,7 @@ static int brcmf_pno_add_ssid(struct brcmf_if *ifp, struct cfg80211_ssid *ssid,
137 pfn.wpa_auth = cpu_to_le32(BRCMF_PNO_WPA_AUTH_ANY); 137 pfn.wpa_auth = cpu_to_le32(BRCMF_PNO_WPA_AUTH_ANY);
138 pfn.wsec = cpu_to_le32(0); 138 pfn.wsec = cpu_to_le32(0);
139 pfn.infra = cpu_to_le32(1); 139 pfn.infra = cpu_to_le32(1);
140 pfn.flags = 0;
140 if (active) 141 if (active)
141 pfn.flags = cpu_to_le32(1 << BRCMF_PNO_HIDDEN_BIT); 142 pfn.flags = cpu_to_le32(1 << BRCMF_PNO_HIDDEN_BIT);
142 pfn.ssid.SSID_len = cpu_to_le32(ssid->ssid_len); 143 pfn.ssid.SSID_len = cpu_to_le32(ssid->ssid_len);