diff options
author | Anusha Srivatsa <anusha.srivatsa@intel.com> | 2018-01-03 14:03:45 -0500 |
---|---|---|
committer | Rodrigo Vivi <rodrigo.vivi@intel.com> | 2018-02-01 10:31:12 -0500 |
commit | 2afba81c7909ac259720c0d3e7616cf54d4a5368 (patch) | |
tree | 00f8711e559fa9bb8d13a6ceb54a2ca7030cddc7 | |
parent | 8466169ab9fe9f0c3412881116aca895feea6e70 (diff) |
drm/i915/glk: Disable Guc and HuC on GLK
Since the firmwares are not yet released to public repo,
disable them on Geminilake.
v2: Remove the firmware versions (Michal)
v3: Remove unwanted defines (Rodrigo)
Correct commit message (Michal)
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Fixes: 90f192c8241e ("drm/i915/GuC/GLK: Load GuC on GLK")
Fixes: db5ba0d8931e ("drm/i915/GLK/HuC: Load HuC on GLK")
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1515006225-13003-1-git-send-email-anusha.srivatsa@intel.com
(cherry picked from commit a76050a4837860fcadb6ca11d69d41e08f4090d8)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
-rw-r--r-- | drivers/gpu/drm/i915/intel_guc_fw.c | 9 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_huc.c | 11 |
2 files changed, 0 insertions, 20 deletions
diff --git a/drivers/gpu/drm/i915/intel_guc_fw.c b/drivers/gpu/drm/i915/intel_guc_fw.c index cbc51c960425..3b0932942857 100644 --- a/drivers/gpu/drm/i915/intel_guc_fw.c +++ b/drivers/gpu/drm/i915/intel_guc_fw.c | |||
@@ -39,9 +39,6 @@ | |||
39 | #define KBL_FW_MAJOR 9 | 39 | #define KBL_FW_MAJOR 9 |
40 | #define KBL_FW_MINOR 39 | 40 | #define KBL_FW_MINOR 39 |
41 | 41 | ||
42 | #define GLK_FW_MAJOR 10 | ||
43 | #define GLK_FW_MINOR 56 | ||
44 | |||
45 | #define GUC_FW_PATH(platform, major, minor) \ | 42 | #define GUC_FW_PATH(platform, major, minor) \ |
46 | "i915/" __stringify(platform) "_guc_ver" __stringify(major) "_" __stringify(minor) ".bin" | 43 | "i915/" __stringify(platform) "_guc_ver" __stringify(major) "_" __stringify(minor) ".bin" |
47 | 44 | ||
@@ -54,8 +51,6 @@ MODULE_FIRMWARE(I915_BXT_GUC_UCODE); | |||
54 | #define I915_KBL_GUC_UCODE GUC_FW_PATH(kbl, KBL_FW_MAJOR, KBL_FW_MINOR) | 51 | #define I915_KBL_GUC_UCODE GUC_FW_PATH(kbl, KBL_FW_MAJOR, KBL_FW_MINOR) |
55 | MODULE_FIRMWARE(I915_KBL_GUC_UCODE); | 52 | MODULE_FIRMWARE(I915_KBL_GUC_UCODE); |
56 | 53 | ||
57 | #define I915_GLK_GUC_UCODE GUC_FW_PATH(glk, GLK_FW_MAJOR, GLK_FW_MINOR) | ||
58 | |||
59 | static void guc_fw_select(struct intel_uc_fw *guc_fw) | 54 | static void guc_fw_select(struct intel_uc_fw *guc_fw) |
60 | { | 55 | { |
61 | struct intel_guc *guc = container_of(guc_fw, struct intel_guc, fw); | 56 | struct intel_guc *guc = container_of(guc_fw, struct intel_guc, fw); |
@@ -82,10 +77,6 @@ static void guc_fw_select(struct intel_uc_fw *guc_fw) | |||
82 | guc_fw->path = I915_KBL_GUC_UCODE; | 77 | guc_fw->path = I915_KBL_GUC_UCODE; |
83 | guc_fw->major_ver_wanted = KBL_FW_MAJOR; | 78 | guc_fw->major_ver_wanted = KBL_FW_MAJOR; |
84 | guc_fw->minor_ver_wanted = KBL_FW_MINOR; | 79 | guc_fw->minor_ver_wanted = KBL_FW_MINOR; |
85 | } else if (IS_GEMINILAKE(dev_priv)) { | ||
86 | guc_fw->path = I915_GLK_GUC_UCODE; | ||
87 | guc_fw->major_ver_wanted = GLK_FW_MAJOR; | ||
88 | guc_fw->minor_ver_wanted = GLK_FW_MINOR; | ||
89 | } else { | 80 | } else { |
90 | DRM_WARN("%s: No firmware known for this platform!\n", | 81 | DRM_WARN("%s: No firmware known for this platform!\n", |
91 | intel_uc_fw_type_repr(guc_fw->type)); | 82 | intel_uc_fw_type_repr(guc_fw->type)); |
diff --git a/drivers/gpu/drm/i915/intel_huc.c b/drivers/gpu/drm/i915/intel_huc.c index 974be3defa70..8ed05182f944 100644 --- a/drivers/gpu/drm/i915/intel_huc.c +++ b/drivers/gpu/drm/i915/intel_huc.c | |||
@@ -54,10 +54,6 @@ | |||
54 | #define KBL_HUC_FW_MINOR 00 | 54 | #define KBL_HUC_FW_MINOR 00 |
55 | #define KBL_BLD_NUM 1810 | 55 | #define KBL_BLD_NUM 1810 |
56 | 56 | ||
57 | #define GLK_HUC_FW_MAJOR 02 | ||
58 | #define GLK_HUC_FW_MINOR 00 | ||
59 | #define GLK_BLD_NUM 1748 | ||
60 | |||
61 | #define HUC_FW_PATH(platform, major, minor, bld_num) \ | 57 | #define HUC_FW_PATH(platform, major, minor, bld_num) \ |
62 | "i915/" __stringify(platform) "_huc_ver" __stringify(major) "_" \ | 58 | "i915/" __stringify(platform) "_huc_ver" __stringify(major) "_" \ |
63 | __stringify(minor) "_" __stringify(bld_num) ".bin" | 59 | __stringify(minor) "_" __stringify(bld_num) ".bin" |
@@ -74,9 +70,6 @@ MODULE_FIRMWARE(I915_BXT_HUC_UCODE); | |||
74 | KBL_HUC_FW_MINOR, KBL_BLD_NUM) | 70 | KBL_HUC_FW_MINOR, KBL_BLD_NUM) |
75 | MODULE_FIRMWARE(I915_KBL_HUC_UCODE); | 71 | MODULE_FIRMWARE(I915_KBL_HUC_UCODE); |
76 | 72 | ||
77 | #define I915_GLK_HUC_UCODE HUC_FW_PATH(glk, GLK_HUC_FW_MAJOR, \ | ||
78 | GLK_HUC_FW_MINOR, GLK_BLD_NUM) | ||
79 | |||
80 | static void huc_fw_select(struct intel_uc_fw *huc_fw) | 73 | static void huc_fw_select(struct intel_uc_fw *huc_fw) |
81 | { | 74 | { |
82 | struct intel_huc *huc = container_of(huc_fw, struct intel_huc, fw); | 75 | struct intel_huc *huc = container_of(huc_fw, struct intel_huc, fw); |
@@ -103,10 +96,6 @@ static void huc_fw_select(struct intel_uc_fw *huc_fw) | |||
103 | huc_fw->path = I915_KBL_HUC_UCODE; | 96 | huc_fw->path = I915_KBL_HUC_UCODE; |
104 | huc_fw->major_ver_wanted = KBL_HUC_FW_MAJOR; | 97 | huc_fw->major_ver_wanted = KBL_HUC_FW_MAJOR; |
105 | huc_fw->minor_ver_wanted = KBL_HUC_FW_MINOR; | 98 | huc_fw->minor_ver_wanted = KBL_HUC_FW_MINOR; |
106 | } else if (IS_GEMINILAKE(dev_priv)) { | ||
107 | huc_fw->path = I915_GLK_HUC_UCODE; | ||
108 | huc_fw->major_ver_wanted = GLK_HUC_FW_MAJOR; | ||
109 | huc_fw->minor_ver_wanted = GLK_HUC_FW_MINOR; | ||
110 | } else { | 99 | } else { |
111 | DRM_WARN("%s: No firmware known for this platform!\n", | 100 | DRM_WARN("%s: No firmware known for this platform!\n", |
112 | intel_uc_fw_type_repr(huc_fw->type)); | 101 | intel_uc_fw_type_repr(huc_fw->type)); |