aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChengguang Xu <cgxu519@gmx.com>2018-09-24 02:10:15 -0400
committerJan Kara <jack@suse.cz>2018-09-24 15:34:15 -0400
commit2aad26fa0a3de74b9c773bc8cb868892f099ccc7 (patch)
tree7a37e025468a464b7300069c3eef47b54e712317
parent1abefb02749f2a39b8020a1d95f7101f2d91e646 (diff)
ext2: remove redundant building macro check
If macro CONFIG_QUOTA is not enabled then mount option flag of usrquota/grpquota will not be set, so we can remove some building macro check safely in ext2_shwo_options(). Additionally, I think it's better to define EXT2_MOUNT_DAX regardless macro CONFIG_FS_DAX is enabled just like acl/xattr. Signed-off-by: Chengguang Xu <cgxu519@gmx.com> Signed-off-by: Jan Kara <jack@suse.cz>
-rw-r--r--fs/ext2/ext2.h4
-rw-r--r--fs/ext2/super.c5
2 files changed, 1 insertions, 8 deletions
diff --git a/fs/ext2/ext2.h b/fs/ext2/ext2.h
index 00e759f05161..e770cd100a6a 100644
--- a/fs/ext2/ext2.h
+++ b/fs/ext2/ext2.h
@@ -390,11 +390,7 @@ struct ext2_inode {
390#define EXT2_MOUNT_USRQUOTA 0x020000 /* user quota */ 390#define EXT2_MOUNT_USRQUOTA 0x020000 /* user quota */
391#define EXT2_MOUNT_GRPQUOTA 0x040000 /* group quota */ 391#define EXT2_MOUNT_GRPQUOTA 0x040000 /* group quota */
392#define EXT2_MOUNT_RESERVATION 0x080000 /* Preallocation */ 392#define EXT2_MOUNT_RESERVATION 0x080000 /* Preallocation */
393#ifdef CONFIG_FS_DAX
394#define EXT2_MOUNT_DAX 0x100000 /* Direct Access */ 393#define EXT2_MOUNT_DAX 0x100000 /* Direct Access */
395#else
396#define EXT2_MOUNT_DAX 0
397#endif
398 394
399 395
400#define clear_opt(o, opt) o &= ~EXT2_MOUNT_##opt 396#define clear_opt(o, opt) o &= ~EXT2_MOUNT_##opt
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 73bd58fa13de..cb91baa4275d 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -309,20 +309,17 @@ static int ext2_show_options(struct seq_file *seq, struct dentry *root)
309 if (test_opt(sb, NOBH)) 309 if (test_opt(sb, NOBH))
310 seq_puts(seq, ",nobh"); 310 seq_puts(seq, ",nobh");
311 311
312#if defined(CONFIG_QUOTA)
313 if (sbi->s_mount_opt & EXT2_MOUNT_USRQUOTA) 312 if (sbi->s_mount_opt & EXT2_MOUNT_USRQUOTA)
314 seq_puts(seq, ",usrquota"); 313 seq_puts(seq, ",usrquota");
315 314
316 if (sbi->s_mount_opt & EXT2_MOUNT_GRPQUOTA) 315 if (sbi->s_mount_opt & EXT2_MOUNT_GRPQUOTA)
317 seq_puts(seq, ",grpquota"); 316 seq_puts(seq, ",grpquota");
318#endif
319 317
320#ifdef CONFIG_FS_DAX
321 if (sbi->s_mount_opt & EXT2_MOUNT_XIP) 318 if (sbi->s_mount_opt & EXT2_MOUNT_XIP)
322 seq_puts(seq, ",xip"); 319 seq_puts(seq, ",xip");
320
323 if (sbi->s_mount_opt & EXT2_MOUNT_DAX) 321 if (sbi->s_mount_opt & EXT2_MOUNT_DAX)
324 seq_puts(seq, ",dax"); 322 seq_puts(seq, ",dax");
325#endif
326 323
327 if (!test_opt(sb, RESERVATION)) 324 if (!test_opt(sb, RESERVATION))
328 seq_puts(seq, ",noreservation"); 325 seq_puts(seq, ",noreservation");