aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>2017-05-02 09:33:02 -0400
committerMark Brown <broonie@kernel.org>2017-05-14 06:00:18 -0400
commit2a54e845f6e5069666e1749bd952abdc0413910d (patch)
tree630cb3ea4a7b367ff2497dbf8e22358c06c0cd4c
parent2ea659a9ef488125eb46da6eb571de5eae5c43f6 (diff)
ASoC: hisilicon: localize functions without external linkage
A driver for hi6210 sound interface on hi6220 boards includes some functions which has no external linkage. These functions should have static qualifier. This commit adds the qualifier to localize the functions. This issue is detected by sparse: hi6210-i2s.c:100:5: warning: symbol 'hi6210_i2s_startup' was not declared. Should it be static? hi6210-i2s.c:178:6: warning: symbol 'hi6210_i2s_shutdown' was not declared. Should it be static? hi6210-i2s.c:527:27: warning: symbol 'hi6210_i2s_dai_init' was not declared. Should it be static? Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r--sound/soc/hisilicon/hi6210-i2s.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/sound/soc/hisilicon/hi6210-i2s.c b/sound/soc/hisilicon/hi6210-i2s.c
index 45163e5202f5..b193d3beb253 100644
--- a/sound/soc/hisilicon/hi6210-i2s.c
+++ b/sound/soc/hisilicon/hi6210-i2s.c
@@ -97,8 +97,8 @@ static inline u32 hi6210_read_reg(struct hi6210_i2s *i2s, int reg)
97 return readl(i2s->base + reg); 97 return readl(i2s->base + reg);
98} 98}
99 99
100int hi6210_i2s_startup(struct snd_pcm_substream *substream, 100static int hi6210_i2s_startup(struct snd_pcm_substream *substream,
101 struct snd_soc_dai *cpu_dai) 101 struct snd_soc_dai *cpu_dai)
102{ 102{
103 struct hi6210_i2s *i2s = dev_get_drvdata(cpu_dai->dev); 103 struct hi6210_i2s *i2s = dev_get_drvdata(cpu_dai->dev);
104 int ret, n; 104 int ret, n;
@@ -175,8 +175,9 @@ int hi6210_i2s_startup(struct snd_pcm_substream *substream,
175 175
176 return 0; 176 return 0;
177} 177}
178void hi6210_i2s_shutdown(struct snd_pcm_substream *substream, 178
179 struct snd_soc_dai *cpu_dai) 179static void hi6210_i2s_shutdown(struct snd_pcm_substream *substream,
180 struct snd_soc_dai *cpu_dai)
180{ 181{
181 struct hi6210_i2s *i2s = dev_get_drvdata(cpu_dai->dev); 182 struct hi6210_i2s *i2s = dev_get_drvdata(cpu_dai->dev);
182 int n; 183 int n;
@@ -524,7 +525,7 @@ static struct snd_soc_dai_ops hi6210_i2s_dai_ops = {
524 .shutdown = hi6210_i2s_shutdown, 525 .shutdown = hi6210_i2s_shutdown,
525}; 526};
526 527
527struct snd_soc_dai_driver hi6210_i2s_dai_init = { 528static const struct snd_soc_dai_driver hi6210_i2s_dai_init = {
528 .probe = hi6210_i2s_dai_probe, 529 .probe = hi6210_i2s_dai_probe,
529 .playback = { 530 .playback = {
530 .channels_min = 2, 531 .channels_min = 2,