diff options
author | Egbert Eich <eich@suse.de> | 2014-06-11 08:59:55 -0400 |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2015-11-10 21:27:31 -0500 |
commit | 28fb4cb7fa6f63dc2fbdb5f2564dcbead8e3eee0 (patch) | |
tree | 178c61d4b4f2fa3a56af57163a979d11c65d691b | |
parent | 2565df91a2a834046024a9baed479dc97dcfc712 (diff) |
drm/ast: Initialized data needed to map fbdev memory
Due to a missing initialization there was no way to map fbdev memory.
Thus for example using the Xserver with the fbdev driver failed.
This fix adds initialization for fix.smem_start and fix.smem_len
in the fb_info structure, which fixes this problem.
Requested-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: stable@vger.kernel.org
Signed-off-by: Egbert Eich <eich@suse.de>
[pulled from SuSE tree by me - airlied]
Signed-off-by: Dave Airlie <airlied@redhat.com>
-rw-r--r-- | drivers/gpu/drm/ast/ast_drv.h | 1 | ||||
-rw-r--r-- | drivers/gpu/drm/ast/ast_fb.c | 7 | ||||
-rw-r--r-- | drivers/gpu/drm/ast/ast_main.c | 1 | ||||
-rw-r--r-- | drivers/gpu/drm/ast/ast_mode.c | 2 |
4 files changed, 11 insertions, 0 deletions
diff --git a/drivers/gpu/drm/ast/ast_drv.h b/drivers/gpu/drm/ast/ast_drv.h index 86205a28e56b..05f6522c0457 100644 --- a/drivers/gpu/drm/ast/ast_drv.h +++ b/drivers/gpu/drm/ast/ast_drv.h | |||
@@ -315,6 +315,7 @@ int ast_framebuffer_init(struct drm_device *dev, | |||
315 | int ast_fbdev_init(struct drm_device *dev); | 315 | int ast_fbdev_init(struct drm_device *dev); |
316 | void ast_fbdev_fini(struct drm_device *dev); | 316 | void ast_fbdev_fini(struct drm_device *dev); |
317 | void ast_fbdev_set_suspend(struct drm_device *dev, int state); | 317 | void ast_fbdev_set_suspend(struct drm_device *dev, int state); |
318 | void ast_fbdev_set_base(struct ast_private *ast, unsigned long gpu_addr); | ||
318 | 319 | ||
319 | struct ast_bo { | 320 | struct ast_bo { |
320 | struct ttm_buffer_object bo; | 321 | struct ttm_buffer_object bo; |
diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c index f31db28a684b..a37e7ea4a00c 100644 --- a/drivers/gpu/drm/ast/ast_fb.c +++ b/drivers/gpu/drm/ast/ast_fb.c | |||
@@ -365,3 +365,10 @@ void ast_fbdev_set_suspend(struct drm_device *dev, int state) | |||
365 | 365 | ||
366 | drm_fb_helper_set_suspend(&ast->fbdev->helper, state); | 366 | drm_fb_helper_set_suspend(&ast->fbdev->helper, state); |
367 | } | 367 | } |
368 | |||
369 | void ast_fbdev_set_base(struct ast_private *ast, unsigned long gpu_addr) | ||
370 | { | ||
371 | ast->fbdev->helper.fbdev->fix.smem_start = | ||
372 | ast->fbdev->helper.fbdev->apertures->ranges[0].base + gpu_addr; | ||
373 | ast->fbdev->helper.fbdev->fix.smem_len = ast->vram_size - gpu_addr; | ||
374 | } | ||
diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c index 838217f8ce7d..541a610667ad 100644 --- a/drivers/gpu/drm/ast/ast_main.c +++ b/drivers/gpu/drm/ast/ast_main.c | |||
@@ -448,6 +448,7 @@ int ast_driver_load(struct drm_device *dev, unsigned long flags) | |||
448 | dev->mode_config.min_height = 0; | 448 | dev->mode_config.min_height = 0; |
449 | dev->mode_config.preferred_depth = 24; | 449 | dev->mode_config.preferred_depth = 24; |
450 | dev->mode_config.prefer_shadow = 1; | 450 | dev->mode_config.prefer_shadow = 1; |
451 | dev->mode_config.fb_base = pci_resource_start(ast->dev->pdev, 0); | ||
451 | 452 | ||
452 | if (ast->chip == AST2100 || | 453 | if (ast->chip == AST2100 || |
453 | ast->chip == AST2200 || | 454 | ast->chip == AST2200 || |
diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index b7ee2634e47c..69d19f3304a5 100644 --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu/drm/ast/ast_mode.c | |||
@@ -547,6 +547,8 @@ static int ast_crtc_do_set_base(struct drm_crtc *crtc, | |||
547 | ret = ttm_bo_kmap(&bo->bo, 0, bo->bo.num_pages, &bo->kmap); | 547 | ret = ttm_bo_kmap(&bo->bo, 0, bo->bo.num_pages, &bo->kmap); |
548 | if (ret) | 548 | if (ret) |
549 | DRM_ERROR("failed to kmap fbcon\n"); | 549 | DRM_ERROR("failed to kmap fbcon\n"); |
550 | else | ||
551 | ast_fbdev_set_base(ast, gpu_addr); | ||
550 | } | 552 | } |
551 | ast_bo_unreserve(bo); | 553 | ast_bo_unreserve(bo); |
552 | 554 | ||