diff options
| author | Heiner Kallweit <hkallweit1@gmail.com> | 2019-03-30 12:13:24 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-03-30 14:04:54 -0400 |
| commit | 288ac524cf70a8e7ed851a61ed2a9744039dae8d (patch) | |
| tree | d06cc15e2d4ab64ca2920846d66defc5b4b72526 | |
| parent | 22bdf7d459ceff6eb06a99364b1d75ecb2fcafe5 (diff) | |
r8169: disable default rx interrupt coalescing on RTL8168
It was reported that re-introducing ASPM, in combination with RX
interrupt coalescing, results in significantly increased packet
latency, see [0]. Disabling ASPM or RX interrupt coalescing fixes
the issue. Therefore change the driver's default to disable RX
interrupt coalescing. Users still have the option to enable RX
coalescing via ethtool.
[0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=925496
Fixes: a99790bf5c7f ("r8169: Reinstate ASPM Support")
Reported-by: Mike Crowe <mac@mcrowe.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/realtek/r8169.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 7562ccbbb39a..19efa88f3f02 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c | |||
| @@ -5460,7 +5460,7 @@ static void rtl_hw_start_8168(struct rtl8169_private *tp) | |||
| 5460 | tp->cp_cmd |= PktCntrDisable | INTT_1; | 5460 | tp->cp_cmd |= PktCntrDisable | INTT_1; |
| 5461 | RTL_W16(tp, CPlusCmd, tp->cp_cmd); | 5461 | RTL_W16(tp, CPlusCmd, tp->cp_cmd); |
| 5462 | 5462 | ||
| 5463 | RTL_W16(tp, IntrMitigate, 0x5151); | 5463 | RTL_W16(tp, IntrMitigate, 0x5100); |
| 5464 | 5464 | ||
| 5465 | /* Work around for RxFIFO overflow. */ | 5465 | /* Work around for RxFIFO overflow. */ |
| 5466 | if (tp->mac_version == RTL_GIGA_MAC_VER_11) { | 5466 | if (tp->mac_version == RTL_GIGA_MAC_VER_11) { |