aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarc Zyngier <marc.zyngier@arm.com>2015-12-16 10:41:12 -0500
committerMarc Zyngier <marc.zyngier@arm.com>2015-12-18 05:15:11 -0500
commit281243cbe075d27ab884858d6e0b15d8ed61bc25 (patch)
tree7322280540ff3b53190038db98bf3b9682c6de2d
parente078ef81514222ffc10bf1767c15df16ca0b84db (diff)
arm64: KVM: debug: Remove spurious inline attributes
The debug trapping code is pretty heavy on the "inline" attribute, but most functions are actually referenced in the sysreg tables, making the inlining imposible. Removing the useless inline qualifier seems the right thing to do, having verified that the output code is similar. Cc: Alex Bennée <alex.bennee@linaro.org> Acked-by: Christoffer Dall <christoffer.dall@linaro.org> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
-rw-r--r--arch/arm64/kvm/sys_regs.c58
1 files changed, 29 insertions, 29 deletions
diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c
index 88adebfab0bd..eec3598b4184 100644
--- a/arch/arm64/kvm/sys_regs.c
+++ b/arch/arm64/kvm/sys_regs.c
@@ -220,9 +220,9 @@ static bool trap_debug_regs(struct kvm_vcpu *vcpu,
220 * All writes will set the KVM_ARM64_DEBUG_DIRTY flag to ensure the 220 * All writes will set the KVM_ARM64_DEBUG_DIRTY flag to ensure the
221 * hyp.S code switches between host and guest values in future. 221 * hyp.S code switches between host and guest values in future.
222 */ 222 */
223static inline void reg_to_dbg(struct kvm_vcpu *vcpu, 223static void reg_to_dbg(struct kvm_vcpu *vcpu,
224 struct sys_reg_params *p, 224 struct sys_reg_params *p,
225 u64 *dbg_reg) 225 u64 *dbg_reg)
226{ 226{
227 u64 val = p->regval; 227 u64 val = p->regval;
228 228
@@ -235,18 +235,18 @@ static inline void reg_to_dbg(struct kvm_vcpu *vcpu,
235 vcpu->arch.debug_flags |= KVM_ARM64_DEBUG_DIRTY; 235 vcpu->arch.debug_flags |= KVM_ARM64_DEBUG_DIRTY;
236} 236}
237 237
238static inline void dbg_to_reg(struct kvm_vcpu *vcpu, 238static void dbg_to_reg(struct kvm_vcpu *vcpu,
239 struct sys_reg_params *p, 239 struct sys_reg_params *p,
240 u64 *dbg_reg) 240 u64 *dbg_reg)
241{ 241{
242 p->regval = *dbg_reg; 242 p->regval = *dbg_reg;
243 if (p->is_32bit) 243 if (p->is_32bit)
244 p->regval &= 0xffffffffUL; 244 p->regval &= 0xffffffffUL;
245} 245}
246 246
247static inline bool trap_bvr(struct kvm_vcpu *vcpu, 247static bool trap_bvr(struct kvm_vcpu *vcpu,
248 struct sys_reg_params *p, 248 struct sys_reg_params *p,
249 const struct sys_reg_desc *rd) 249 const struct sys_reg_desc *rd)
250{ 250{
251 u64 *dbg_reg = &vcpu->arch.vcpu_debug_state.dbg_bvr[rd->reg]; 251 u64 *dbg_reg = &vcpu->arch.vcpu_debug_state.dbg_bvr[rd->reg];
252 252
@@ -280,15 +280,15 @@ static int get_bvr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *rd,
280 return 0; 280 return 0;
281} 281}
282 282
283static inline void reset_bvr(struct kvm_vcpu *vcpu, 283static void reset_bvr(struct kvm_vcpu *vcpu,
284 const struct sys_reg_desc *rd) 284 const struct sys_reg_desc *rd)
285{ 285{
286 vcpu->arch.vcpu_debug_state.dbg_bvr[rd->reg] = rd->val; 286 vcpu->arch.vcpu_debug_state.dbg_bvr[rd->reg] = rd->val;
287} 287}
288 288
289static inline bool trap_bcr(struct kvm_vcpu *vcpu, 289static bool trap_bcr(struct kvm_vcpu *vcpu,
290 struct sys_reg_params *p, 290 struct sys_reg_params *p,
291 const struct sys_reg_desc *rd) 291 const struct sys_reg_desc *rd)
292{ 292{
293 u64 *dbg_reg = &vcpu->arch.vcpu_debug_state.dbg_bcr[rd->reg]; 293 u64 *dbg_reg = &vcpu->arch.vcpu_debug_state.dbg_bcr[rd->reg];
294 294
@@ -323,15 +323,15 @@ static int get_bcr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *rd,
323 return 0; 323 return 0;
324} 324}
325 325
326static inline void reset_bcr(struct kvm_vcpu *vcpu, 326static void reset_bcr(struct kvm_vcpu *vcpu,
327 const struct sys_reg_desc *rd) 327 const struct sys_reg_desc *rd)
328{ 328{
329 vcpu->arch.vcpu_debug_state.dbg_bcr[rd->reg] = rd->val; 329 vcpu->arch.vcpu_debug_state.dbg_bcr[rd->reg] = rd->val;
330} 330}
331 331
332static inline bool trap_wvr(struct kvm_vcpu *vcpu, 332static bool trap_wvr(struct kvm_vcpu *vcpu,
333 struct sys_reg_params *p, 333 struct sys_reg_params *p,
334 const struct sys_reg_desc *rd) 334 const struct sys_reg_desc *rd)
335{ 335{
336 u64 *dbg_reg = &vcpu->arch.vcpu_debug_state.dbg_wvr[rd->reg]; 336 u64 *dbg_reg = &vcpu->arch.vcpu_debug_state.dbg_wvr[rd->reg];
337 337
@@ -366,15 +366,15 @@ static int get_wvr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *rd,
366 return 0; 366 return 0;
367} 367}
368 368
369static inline void reset_wvr(struct kvm_vcpu *vcpu, 369static void reset_wvr(struct kvm_vcpu *vcpu,
370 const struct sys_reg_desc *rd) 370 const struct sys_reg_desc *rd)
371{ 371{
372 vcpu->arch.vcpu_debug_state.dbg_wvr[rd->reg] = rd->val; 372 vcpu->arch.vcpu_debug_state.dbg_wvr[rd->reg] = rd->val;
373} 373}
374 374
375static inline bool trap_wcr(struct kvm_vcpu *vcpu, 375static bool trap_wcr(struct kvm_vcpu *vcpu,
376 struct sys_reg_params *p, 376 struct sys_reg_params *p,
377 const struct sys_reg_desc *rd) 377 const struct sys_reg_desc *rd)
378{ 378{
379 u64 *dbg_reg = &vcpu->arch.vcpu_debug_state.dbg_wcr[rd->reg]; 379 u64 *dbg_reg = &vcpu->arch.vcpu_debug_state.dbg_wcr[rd->reg];
380 380
@@ -408,8 +408,8 @@ static int get_wcr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *rd,
408 return 0; 408 return 0;
409} 409}
410 410
411static inline void reset_wcr(struct kvm_vcpu *vcpu, 411static void reset_wcr(struct kvm_vcpu *vcpu,
412 const struct sys_reg_desc *rd) 412 const struct sys_reg_desc *rd)
413{ 413{
414 vcpu->arch.vcpu_debug_state.dbg_wcr[rd->reg] = rd->val; 414 vcpu->arch.vcpu_debug_state.dbg_wcr[rd->reg] = rd->val;
415} 415}
@@ -723,9 +723,9 @@ static bool trap_debug32(struct kvm_vcpu *vcpu,
723 * system is in. 723 * system is in.
724 */ 724 */
725 725
726static inline bool trap_xvr(struct kvm_vcpu *vcpu, 726static bool trap_xvr(struct kvm_vcpu *vcpu,
727 struct sys_reg_params *p, 727 struct sys_reg_params *p,
728 const struct sys_reg_desc *rd) 728 const struct sys_reg_desc *rd)
729{ 729{
730 u64 *dbg_reg = &vcpu->arch.vcpu_debug_state.dbg_bvr[rd->reg]; 730 u64 *dbg_reg = &vcpu->arch.vcpu_debug_state.dbg_bvr[rd->reg];
731 731