diff options
author | Chris Wilson <chris@chris-wilson.co.uk> | 2016-10-03 08:45:16 -0400 |
---|---|---|
committer | Jani Nikula <jani.nikula@intel.com> | 2016-10-10 09:06:42 -0400 |
commit | 27399eeec28ff33a0c5216a80cf57cbc6ba3c15e (patch) | |
tree | 2161f38161f0e0db295a7e96818acb1240538405 | |
parent | ca5732c53bf66ad755284786897e0dd10330de87 (diff) |
drm/i915: Use correct index for backtracking HUNG semaphores
When decoding the semaphores inside hangcheck, we need to use the hw-id
and not the local array index.
Fixes: de1add360522 ("drm/i915: Decouple execbuf uAPI ...")
Testcase: igt/gem_exec_whisper/hang # gen6-7
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: stable@vger.kernel.org
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20161003124516.12388-3-chris@chris-wilson.co.uk
(cherry picked from commit 348b9b1192144e13b779f8f9be301d492bebaff2)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
-rw-r--r-- | drivers/gpu/drm/i915/i915_irq.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c index 13fae1c9dcc8..3fc286cd1157 100644 --- a/drivers/gpu/drm/i915/i915_irq.c +++ b/drivers/gpu/drm/i915/i915_irq.c | |||
@@ -2822,7 +2822,7 @@ semaphore_wait_to_signaller_ring(struct intel_engine_cs *engine, u32 ipehr, | |||
2822 | if (engine == signaller) | 2822 | if (engine == signaller) |
2823 | continue; | 2823 | continue; |
2824 | 2824 | ||
2825 | if (offset == signaller->semaphore.signal_ggtt[engine->id]) | 2825 | if (offset == signaller->semaphore.signal_ggtt[engine->hw_id]) |
2826 | return signaller; | 2826 | return signaller; |
2827 | } | 2827 | } |
2828 | } else { | 2828 | } else { |
@@ -2832,13 +2832,13 @@ semaphore_wait_to_signaller_ring(struct intel_engine_cs *engine, u32 ipehr, | |||
2832 | if(engine == signaller) | 2832 | if(engine == signaller) |
2833 | continue; | 2833 | continue; |
2834 | 2834 | ||
2835 | if (sync_bits == signaller->semaphore.mbox.wait[engine->id]) | 2835 | if (sync_bits == signaller->semaphore.mbox.wait[engine->hw_id]) |
2836 | return signaller; | 2836 | return signaller; |
2837 | } | 2837 | } |
2838 | } | 2838 | } |
2839 | 2839 | ||
2840 | DRM_DEBUG_DRIVER("No signaller ring found for ring %i, ipehr 0x%08x, offset 0x%016llx\n", | 2840 | DRM_DEBUG_DRIVER("No signaller ring found for %s, ipehr 0x%08x, offset 0x%016llx\n", |
2841 | engine->id, ipehr, offset); | 2841 | engine->name, ipehr, offset); |
2842 | 2842 | ||
2843 | return ERR_PTR(-ENODEV); | 2843 | return ERR_PTR(-ENODEV); |
2844 | } | 2844 | } |