diff options
author | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2016-01-28 21:48:37 -0500 |
---|---|---|
committer | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2016-03-31 16:34:04 -0400 |
commit | 26ece8ef6eca97f19eb5ad5186b8c1a29ab25d76 (patch) | |
tree | 020a39c972eabb6899f0b63d0d1d5b69429bfae9 | |
parent | a1e1224849d9610b50fd1dd7d6f44308a59e46af (diff) |
rcu: Fix synchronize_rcu_expedited() header comment
This commit brings the synchronize_rcu_expedited() function's header
comment into line with the new implementation.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
-rw-r--r-- | kernel/rcu/tree_plugin.h | 20 |
1 files changed, 13 insertions, 7 deletions
diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h index efdf7b61ce12..a2ac2628ef8e 100644 --- a/kernel/rcu/tree_plugin.h +++ b/kernel/rcu/tree_plugin.h | |||
@@ -722,13 +722,19 @@ static void sync_rcu_exp_handler(void *info) | |||
722 | * synchronize_rcu_expedited - Brute-force RCU grace period | 722 | * synchronize_rcu_expedited - Brute-force RCU grace period |
723 | * | 723 | * |
724 | * Wait for an RCU-preempt grace period, but expedite it. The basic | 724 | * Wait for an RCU-preempt grace period, but expedite it. The basic |
725 | * idea is to invoke synchronize_sched_expedited() to push all the tasks to | 725 | * idea is to IPI all non-idle non-nohz online CPUs. The IPI handler |
726 | * the ->blkd_tasks lists and wait for this list to drain. This consumes | 726 | * checks whether the CPU is in an RCU-preempt critical section, and |
727 | * significant time on all CPUs and is unfriendly to real-time workloads, | 727 | * if so, it sets a flag that causes the outermost rcu_read_unlock() |
728 | * so is thus not recommended for any sort of common-case code. | 728 | * to report the quiescent state. On the other hand, if the CPU is |
729 | * In fact, if you are using synchronize_rcu_expedited() in a loop, | 729 | * not in an RCU read-side critical section, the IPI handler reports |
730 | * please restructure your code to batch your updates, and then Use a | 730 | * the quiescent state immediately. |
731 | * single synchronize_rcu() instead. | 731 | * |
732 | * Although this is a greate improvement over previous expedited | ||
733 | * implementations, it is still unfriendly to real-time workloads, so is | ||
734 | * thus not recommended for any sort of common-case code. In fact, if | ||
735 | * you are using synchronize_rcu_expedited() in a loop, please restructure | ||
736 | * your code to batch your updates, and then Use a single synchronize_rcu() | ||
737 | * instead. | ||
732 | */ | 738 | */ |
733 | void synchronize_rcu_expedited(void) | 739 | void synchronize_rcu_expedited(void) |
734 | { | 740 | { |