diff options
author | Boris Brezillon <boris.brezillon@free-electrons.com> | 2016-06-07 07:48:08 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2016-06-10 11:24:48 -0400 |
commit | 26b4ee34e74f230d4b1783b89b2418863d6eb6f2 (patch) | |
tree | 3696c377088e5e881954986d6cab3d4832243739 | |
parent | 99410f35944e2bf98c609a6ff164c30158050b60 (diff) |
drm: tegra: Rely on the default ->best_encoder() behavior
All outputs have a 1:1 relationship between connectors and encoders
and the driver is relying on the atomic helpers: we can drop the custom
->best_encoder() implementation and let the core call
drm_atomic_helper_best_encoder() for us.
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1465300095-16971-14-git-send-email-boris.brezillon@free-electrons.com
-rw-r--r-- | drivers/gpu/drm/tegra/drm.h | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/tegra/dsi.c | 1 | ||||
-rw-r--r-- | drivers/gpu/drm/tegra/hdmi.c | 1 | ||||
-rw-r--r-- | drivers/gpu/drm/tegra/output.c | 8 | ||||
-rw-r--r-- | drivers/gpu/drm/tegra/rgb.c | 1 | ||||
-rw-r--r-- | drivers/gpu/drm/tegra/sor.c | 1 |
6 files changed, 0 insertions, 14 deletions
diff --git a/drivers/gpu/drm/tegra/drm.h b/drivers/gpu/drm/tegra/drm.h index f52d6cb24ff5..0ddcce1b420d 100644 --- a/drivers/gpu/drm/tegra/drm.h +++ b/drivers/gpu/drm/tegra/drm.h | |||
@@ -239,8 +239,6 @@ int tegra_output_init(struct drm_device *drm, struct tegra_output *output); | |||
239 | void tegra_output_exit(struct tegra_output *output); | 239 | void tegra_output_exit(struct tegra_output *output); |
240 | 240 | ||
241 | int tegra_output_connector_get_modes(struct drm_connector *connector); | 241 | int tegra_output_connector_get_modes(struct drm_connector *connector); |
242 | struct drm_encoder * | ||
243 | tegra_output_connector_best_encoder(struct drm_connector *connector); | ||
244 | enum drm_connector_status | 242 | enum drm_connector_status |
245 | tegra_output_connector_detect(struct drm_connector *connector, bool force); | 243 | tegra_output_connector_detect(struct drm_connector *connector, bool force); |
246 | void tegra_output_connector_destroy(struct drm_connector *connector); | 244 | void tegra_output_connector_destroy(struct drm_connector *connector); |
diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index d1239ebc190f..099cccb2fbcb 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/dsi.c | |||
@@ -794,7 +794,6 @@ tegra_dsi_connector_mode_valid(struct drm_connector *connector, | |||
794 | static const struct drm_connector_helper_funcs tegra_dsi_connector_helper_funcs = { | 794 | static const struct drm_connector_helper_funcs tegra_dsi_connector_helper_funcs = { |
795 | .get_modes = tegra_output_connector_get_modes, | 795 | .get_modes = tegra_output_connector_get_modes, |
796 | .mode_valid = tegra_dsi_connector_mode_valid, | 796 | .mode_valid = tegra_dsi_connector_mode_valid, |
797 | .best_encoder = tegra_output_connector_best_encoder, | ||
798 | }; | 797 | }; |
799 | 798 | ||
800 | static const struct drm_encoder_funcs tegra_dsi_encoder_funcs = { | 799 | static const struct drm_encoder_funcs tegra_dsi_encoder_funcs = { |
diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c index b7ef4929e347..2fdb8796443e 100644 --- a/drivers/gpu/drm/tegra/hdmi.c +++ b/drivers/gpu/drm/tegra/hdmi.c | |||
@@ -806,7 +806,6 @@ static const struct drm_connector_helper_funcs | |||
806 | tegra_hdmi_connector_helper_funcs = { | 806 | tegra_hdmi_connector_helper_funcs = { |
807 | .get_modes = tegra_output_connector_get_modes, | 807 | .get_modes = tegra_output_connector_get_modes, |
808 | .mode_valid = tegra_hdmi_connector_mode_valid, | 808 | .mode_valid = tegra_hdmi_connector_mode_valid, |
809 | .best_encoder = tegra_output_connector_best_encoder, | ||
810 | }; | 809 | }; |
811 | 810 | ||
812 | static const struct drm_encoder_funcs tegra_hdmi_encoder_funcs = { | 811 | static const struct drm_encoder_funcs tegra_hdmi_encoder_funcs = { |
diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c index 46664b622270..1480f6aaffe4 100644 --- a/drivers/gpu/drm/tegra/output.c +++ b/drivers/gpu/drm/tegra/output.c | |||
@@ -42,14 +42,6 @@ int tegra_output_connector_get_modes(struct drm_connector *connector) | |||
42 | return err; | 42 | return err; |
43 | } | 43 | } |
44 | 44 | ||
45 | struct drm_encoder * | ||
46 | tegra_output_connector_best_encoder(struct drm_connector *connector) | ||
47 | { | ||
48 | struct tegra_output *output = connector_to_output(connector); | ||
49 | |||
50 | return &output->encoder; | ||
51 | } | ||
52 | |||
53 | enum drm_connector_status | 45 | enum drm_connector_status |
54 | tegra_output_connector_detect(struct drm_connector *connector, bool force) | 46 | tegra_output_connector_detect(struct drm_connector *connector, bool force) |
55 | { | 47 | { |
diff --git a/drivers/gpu/drm/tegra/rgb.c b/drivers/gpu/drm/tegra/rgb.c index e246334e0252..a131b44e2d6f 100644 --- a/drivers/gpu/drm/tegra/rgb.c +++ b/drivers/gpu/drm/tegra/rgb.c | |||
@@ -112,7 +112,6 @@ tegra_rgb_connector_mode_valid(struct drm_connector *connector, | |||
112 | static const struct drm_connector_helper_funcs tegra_rgb_connector_helper_funcs = { | 112 | static const struct drm_connector_helper_funcs tegra_rgb_connector_helper_funcs = { |
113 | .get_modes = tegra_output_connector_get_modes, | 113 | .get_modes = tegra_output_connector_get_modes, |
114 | .mode_valid = tegra_rgb_connector_mode_valid, | 114 | .mode_valid = tegra_rgb_connector_mode_valid, |
115 | .best_encoder = tegra_output_connector_best_encoder, | ||
116 | }; | 115 | }; |
117 | 116 | ||
118 | static const struct drm_encoder_funcs tegra_rgb_encoder_funcs = { | 117 | static const struct drm_encoder_funcs tegra_rgb_encoder_funcs = { |
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index 757c6e8603af..34958d71284b 100644 --- a/drivers/gpu/drm/tegra/sor.c +++ b/drivers/gpu/drm/tegra/sor.c | |||
@@ -1087,7 +1087,6 @@ tegra_sor_connector_mode_valid(struct drm_connector *connector, | |||
1087 | static const struct drm_connector_helper_funcs tegra_sor_connector_helper_funcs = { | 1087 | static const struct drm_connector_helper_funcs tegra_sor_connector_helper_funcs = { |
1088 | .get_modes = tegra_sor_connector_get_modes, | 1088 | .get_modes = tegra_sor_connector_get_modes, |
1089 | .mode_valid = tegra_sor_connector_mode_valid, | 1089 | .mode_valid = tegra_sor_connector_mode_valid, |
1090 | .best_encoder = tegra_output_connector_best_encoder, | ||
1091 | }; | 1090 | }; |
1092 | 1091 | ||
1093 | static const struct drm_encoder_funcs tegra_sor_encoder_funcs = { | 1092 | static const struct drm_encoder_funcs tegra_sor_encoder_funcs = { |