diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2016-12-13 18:08:02 -0500 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2016-12-18 08:18:12 -0500 |
commit | 25a9939c09eae246173d06e0478f0e131d83b55c (patch) | |
tree | b9be453cb33458f4f964511b2e7c400a99c3c40d | |
parent | 6e15174ecd7ace10f1f996d4bc28b583987fcbac (diff) |
drm/irq: drm_legacy_ prefix for legacy ioctls
Spotted while auditing our ioctl table. Also nuke the
not-really-kerneldoc comments, we don't document internals and
definitely don't want to mislead people with the old dragons.
I think with this all the legacy ioctls now have proper drm_legacy_
prefixes.
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20161213230814.19598-2-daniel.vetter@ffwll.ch
-rw-r--r-- | drivers/gpu/drm/drm_internal.h | 8 | ||||
-rw-r--r-- | drivers/gpu/drm/drm_ioctl.c | 4 | ||||
-rw-r--r-- | drivers/gpu/drm/drm_irq.c | 30 |
3 files changed, 10 insertions, 32 deletions
diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h index db80ec860e33..a6213f814345 100644 --- a/drivers/gpu/drm/drm_internal.h +++ b/drivers/gpu/drm/drm_internal.h | |||
@@ -58,10 +58,10 @@ extern unsigned int drm_timestamp_monotonic; | |||
58 | /* IOCTLS */ | 58 | /* IOCTLS */ |
59 | int drm_wait_vblank(struct drm_device *dev, void *data, | 59 | int drm_wait_vblank(struct drm_device *dev, void *data, |
60 | struct drm_file *filp); | 60 | struct drm_file *filp); |
61 | int drm_control(struct drm_device *dev, void *data, | 61 | int drm_legacy_irq_control(struct drm_device *dev, void *data, |
62 | struct drm_file *file_priv); | 62 | struct drm_file *file_priv); |
63 | int drm_modeset_ctl(struct drm_device *dev, void *data, | 63 | int drm_legacy_modeset_ctl(struct drm_device *dev, void *data, |
64 | struct drm_file *file_priv); | 64 | struct drm_file *file_priv); |
65 | 65 | ||
66 | /* drm_auth.c */ | 66 | /* drm_auth.c */ |
67 | int drm_getmagic(struct drm_device *dev, void *data, | 67 | int drm_getmagic(struct drm_device *dev, void *data, |
diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index 59b691146033..d180673c1323 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c | |||
@@ -581,7 +581,7 @@ static const struct drm_ioctl_desc drm_ioctls[] = { | |||
581 | DRM_IOCTL_DEF(DRM_IOCTL_FREE_BUFS, drm_legacy_freebufs, DRM_AUTH), | 581 | DRM_IOCTL_DEF(DRM_IOCTL_FREE_BUFS, drm_legacy_freebufs, DRM_AUTH), |
582 | DRM_IOCTL_DEF(DRM_IOCTL_DMA, drm_legacy_dma_ioctl, DRM_AUTH), | 582 | DRM_IOCTL_DEF(DRM_IOCTL_DMA, drm_legacy_dma_ioctl, DRM_AUTH), |
583 | 583 | ||
584 | DRM_IOCTL_DEF(DRM_IOCTL_CONTROL, drm_control, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY), | 584 | DRM_IOCTL_DEF(DRM_IOCTL_CONTROL, drm_legacy_irq_control, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY), |
585 | 585 | ||
586 | #if IS_ENABLED(CONFIG_AGP) | 586 | #if IS_ENABLED(CONFIG_AGP) |
587 | DRM_IOCTL_DEF(DRM_IOCTL_AGP_ACQUIRE, drm_agp_acquire_ioctl, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY), | 587 | DRM_IOCTL_DEF(DRM_IOCTL_AGP_ACQUIRE, drm_agp_acquire_ioctl, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY), |
@@ -599,7 +599,7 @@ static const struct drm_ioctl_desc drm_ioctls[] = { | |||
599 | 599 | ||
600 | DRM_IOCTL_DEF(DRM_IOCTL_WAIT_VBLANK, drm_wait_vblank, DRM_UNLOCKED), | 600 | DRM_IOCTL_DEF(DRM_IOCTL_WAIT_VBLANK, drm_wait_vblank, DRM_UNLOCKED), |
601 | 601 | ||
602 | DRM_IOCTL_DEF(DRM_IOCTL_MODESET_CTL, drm_modeset_ctl, 0), | 602 | DRM_IOCTL_DEF(DRM_IOCTL_MODESET_CTL, drm_legacy_modeset_ctl, 0), |
603 | 603 | ||
604 | DRM_IOCTL_DEF(DRM_IOCTL_UPDATE_DRAW, drm_noop, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY), | 604 | DRM_IOCTL_DEF(DRM_IOCTL_UPDATE_DRAW, drm_noop, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY), |
605 | 605 | ||
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c index 273625a85036..feb091310ffe 100644 --- a/drivers/gpu/drm/drm_irq.c +++ b/drivers/gpu/drm/drm_irq.c | |||
@@ -579,19 +579,8 @@ int drm_irq_uninstall(struct drm_device *dev) | |||
579 | } | 579 | } |
580 | EXPORT_SYMBOL(drm_irq_uninstall); | 580 | EXPORT_SYMBOL(drm_irq_uninstall); |
581 | 581 | ||
582 | /* | 582 | int drm_legacy_irq_control(struct drm_device *dev, void *data, |
583 | * IRQ control ioctl. | 583 | struct drm_file *file_priv) |
584 | * | ||
585 | * \param inode device inode. | ||
586 | * \param file_priv DRM file private. | ||
587 | * \param cmd command. | ||
588 | * \param arg user argument, pointing to a drm_control structure. | ||
589 | * \return zero on success or a negative number on failure. | ||
590 | * | ||
591 | * Calls irq_install() or irq_uninstall() according to \p arg. | ||
592 | */ | ||
593 | int drm_control(struct drm_device *dev, void *data, | ||
594 | struct drm_file *file_priv) | ||
595 | { | 584 | { |
596 | struct drm_control *ctl = data; | 585 | struct drm_control *ctl = data; |
597 | int ret = 0, irq; | 586 | int ret = 0, irq; |
@@ -1442,19 +1431,8 @@ static void drm_legacy_vblank_post_modeset(struct drm_device *dev, | |||
1442 | } | 1431 | } |
1443 | } | 1432 | } |
1444 | 1433 | ||
1445 | /* | 1434 | int drm_legacy_modeset_ctl(struct drm_device *dev, void *data, |
1446 | * drm_modeset_ctl - handle vblank event counter changes across mode switch | 1435 | struct drm_file *file_priv) |
1447 | * @DRM_IOCTL_ARGS: standard ioctl arguments | ||
1448 | * | ||
1449 | * Applications should call the %_DRM_PRE_MODESET and %_DRM_POST_MODESET | ||
1450 | * ioctls around modesetting so that any lost vblank events are accounted for. | ||
1451 | * | ||
1452 | * Generally the counter will reset across mode sets. If interrupts are | ||
1453 | * enabled around this call, we don't have to do anything since the counter | ||
1454 | * will have already been incremented. | ||
1455 | */ | ||
1456 | int drm_modeset_ctl(struct drm_device *dev, void *data, | ||
1457 | struct drm_file *file_priv) | ||
1458 | { | 1436 | { |
1459 | struct drm_modeset_ctl *modeset = data; | 1437 | struct drm_modeset_ctl *modeset = data; |
1460 | unsigned int pipe; | 1438 | unsigned int pipe; |