diff options
author | Arnd Bergmann <arnd@arndb.de> | 2017-07-26 11:14:00 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-07-27 20:20:19 -0400 |
commit | 245db3c349e0b413e0fec8d6179f6b767649ad63 (patch) | |
tree | 45733e9526aa0290b97bd6005d8503d6b17126b2 | |
parent | 4c3464a8c31829e6e7efbf8258dc062f761509d7 (diff) |
phy: bcm-ns-usb3: fix MDIO_BUS dependency
The driver attempts to 'select MDIO_DEVICE', but the code
is actually a loadable module when PHYLIB=m:
drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_mdiodev_phy_write':
phy-bcm-ns-usb3.c:(.text.bcm_ns_usb3_mdiodev_phy_write+0x28): undefined reference to `mdiobus_write'
drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_exit':
phy-bcm-ns-usb3.c:(.exit.text+0x18): undefined reference to `mdio_driver_unregister'
drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_module_init':
phy-bcm-ns-usb3.c:(.init.text+0x18): undefined reference to `mdio_driver_register'
phy-bcm-ns-usb3.c:(.init.text+0x38): undefined reference to `mdio_driver_unregister'
Using 'depends on MDIO_BUS' instead will avoid the link error.
Fixes: af850e14a7ae ("phy: bcm-ns-usb3: add MDIO driver using proper bus layer")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/phy/broadcom/Kconfig | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig index 37371b89b14f..64fc59c3ae6d 100644 --- a/drivers/phy/broadcom/Kconfig +++ b/drivers/phy/broadcom/Kconfig | |||
@@ -30,8 +30,8 @@ config PHY_BCM_NS_USB3 | |||
30 | tristate "Broadcom Northstar USB 3.0 PHY Driver" | 30 | tristate "Broadcom Northstar USB 3.0 PHY Driver" |
31 | depends on ARCH_BCM_IPROC || COMPILE_TEST | 31 | depends on ARCH_BCM_IPROC || COMPILE_TEST |
32 | depends on HAS_IOMEM && OF | 32 | depends on HAS_IOMEM && OF |
33 | depends on MDIO_BUS | ||
33 | select GENERIC_PHY | 34 | select GENERIC_PHY |
34 | select MDIO_DEVICE | ||
35 | help | 35 | help |
36 | Enable this to support Broadcom USB 3.0 PHY connected to the USB | 36 | Enable this to support Broadcom USB 3.0 PHY connected to the USB |
37 | controller on Northstar family. | 37 | controller on Northstar family. |