net_sched: remove list_head from tc_action

After commit 90b73b77d08e, list_head is no longer needed.
Now we just need to convert the list iteration to array
iteration for drivers.

Fixes: 90b73b77d08e ("net: sched: change action API to use array of pointers to actions")
Cc: Jiri Pirko <jiri@mellanox.com>
Cc: Vlad Buslov <vladbu@mellanox.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

14 files changed, 43 insertions, 60 deletions

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
index 139d96c5a023..092c817f8f11 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
@@ -110,16 +110,14 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
                                  struct tcf_exts *tc_exts)
 {
         const struct tc_action *tc_act;
-        LIST_HEAD(tc_actions);
-        int rc;
+        int i, rc;
 
         if (!tcf_exts_has_actions(tc_exts)) {
                 netdev_info(bp->dev, "no actions");
                 return -EINVAL;
         }
 
-        tcf_exts_to_list(tc_exts, &tc_actions);
-        list_for_each_entry(tc_act, &tc_actions, list) {
+        tcf_exts_for_each_action(i, tc_act, tc_exts) {
                 /* Drop action */
                 if (is_tcf_gact_shot(tc_act)) {
                         actions->flags |= BNXT_TC_ACTION_FLAG_DROP;
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
index 623f73dd7738..c116f96956fe 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c
@@ -417,10 +417,9 @@ static void cxgb4_process_flow_actions(struct net_device *in,
                                        struct ch_filter_specification *fs)
 {
         const struct tc_action *a;
-        LIST_HEAD(actions);
+        int i;
 
-        tcf_exts_to_list(cls->exts, &actions);
-        list_for_each_entry(a, &actions, list) {
+        tcf_exts_for_each_action(i, a, cls->exts) {
                 if (is_tcf_gact_ok(a)) {
                         fs->action = FILTER_PASS;
                 } else if (is_tcf_gact_shot(a)) {
@@ -591,10 +590,9 @@ static int cxgb4_validate_flow_actions(struct net_device *dev,
         bool act_redir = false;
         bool act_pedit = false;
         bool act_vlan = false;
-        LIST_HEAD(actions);
+        int i;
 
-        tcf_exts_to_list(cls->exts, &actions);
-        list_for_each_entry(a, &actions, list) {
+        tcf_exts_for_each_action(i, a, cls->exts) {
                 if (is_tcf_gact_ok(a)) {
                         /* Do nothing */
                 } else if (is_tcf_gact_shot(a)) {
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c
index 18eb2aedd4cb..c7d2b4dc7568 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c
@@ -93,14 +93,13 @@ static int fill_action_fields(struct adapter *adap,
         unsigned int num_actions = 0;
         const struct tc_action *a;
         struct tcf_exts *exts;
-        LIST_HEAD(actions);
+        int i;
 
         exts = cls->knode.exts;
         if (!tcf_exts_has_actions(exts))
                 return -EINVAL;
 
-        tcf_exts_to_list(exts, &actions);
-        list_for_each_entry(a, &actions, list) {
+        tcf_exts_for_each_action(i, a, exts) {
                 /* Don't allow more than one action per rule. */
                 if (num_actions)
                         return -EINVAL;
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 447098005490..af4c9ae7f432 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -9171,14 +9171,12 @@ static int parse_tc_actions(struct ixgbe_adapter *adapter,
                             struct tcf_exts *exts, u64 *action, u8 *queue)
 {
         const struct tc_action *a;
-        LIST_HEAD(actions);
+        int i;
 
         if (!tcf_exts_has_actions(exts))
                 return -EINVAL;
 
-        tcf_exts_to_list(exts, &actions);
-        list_for_each_entry(a, &actions, list) {
-
+        tcf_exts_for_each_action(i, a, exts) {
                 /* Drop action */
                 if (is_tcf_gact_shot(a)) {
                         *action = IXGBE_FDIR_DROP_QUEUE;
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index 9131a1376e7d..9fed54017659 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -1982,14 +1982,15 @@ static bool modify_header_match_supported(struct mlx5_flow_spec *spec,
                 goto out_ok;
 
         modify_ip_header = false;
-        tcf_exts_to_list(exts, &actions);
-        list_for_each_entry(a, &actions, list) {
+        tcf_exts_for_each_action(i, a, exts) {
+                int k;
+
                 if (!is_tcf_pedit(a))
                         continue;
 
                 nkeys = tcf_pedit_nkeys(a);
-                for (i = 0; i < nkeys; i++) {
-                        htype = tcf_pedit_htype(a, i);
+                for (k = 0; k < nkeys; k++) {
+                        htype = tcf_pedit_htype(a, k);
                         if (htype == TCA_PEDIT_KEY_EX_HDR_TYPE_IP4 ||
                             htype == TCA_PEDIT_KEY_EX_HDR_TYPE_IP6) {
                                 modify_ip_header = true;
@@ -2053,15 +2054,14 @@ static int parse_tc_nic_actions(struct mlx5e_priv *priv, struct tcf_exts *exts,
         const struct tc_action *a;
         LIST_HEAD(actions);
         u32 action = 0;
-        int err;
+        int err, i;
 
         if (!tcf_exts_has_actions(exts))
                 return -EINVAL;
 
         attr->flow_tag = MLX5_FS_DEFAULT_FLOW_TAG;
 
-        tcf_exts_to_list(exts, &actions);
-        list_for_each_entry(a, &actions, list) {
+        tcf_exts_for_each_action(i, a, exts) {
                 if (is_tcf_gact_shot(a)) {
                         action |= MLX5_FLOW_CONTEXT_ACTION_DROP;
                         if (MLX5_CAP_FLOWTABLE(priv->mdev,
@@ -2666,7 +2666,7 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, struct tcf_exts *exts,
         LIST_HEAD(actions);
         bool encap = false;
         u32 action = 0;
-        int err;
+        int err, i;
 
         if (!tcf_exts_has_actions(exts))
                 return -EINVAL;
@@ -2674,8 +2674,7 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, struct tcf_exts *exts,
         attr->in_rep = rpriv->rep;
         attr->in_mdev = priv->mdev;
 
-        tcf_exts_to_list(exts, &actions);
-        list_for_each_entry(a, &actions, list) {
+        tcf_exts_for_each_action(i, a, exts) {
                 if (is_tcf_gact_shot(a)) {
                         action |= MLX5_FLOW_CONTEXT_ACTION_DROP |
                                   MLX5_FLOW_CONTEXT_ACTION_COUNT;
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
index 6070d1591d1e..930700413b1d 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
@@ -1346,8 +1346,7 @@ static int mlxsw_sp_port_add_cls_matchall(struct mlxsw_sp_port *mlxsw_sp_port,
                 return -ENOMEM;
         mall_tc_entry->cookie = f->cookie;
 
-        tcf_exts_to_list(f->exts, &actions);
-        a = list_first_entry(&actions, struct tc_action, list);
+        a = tcf_exts_first_action(f->exts);
 
         if (is_tcf_mirred_egress_mirror(a) && protocol == htons(ETH_P_ALL)) {
                 struct mlxsw_sp_port_mall_mirror_tc_entry *mirror;
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
index ebd1b24ebaa5..8d211972c5e9 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c
@@ -21,8 +21,7 @@ static int mlxsw_sp_flower_parse_actions(struct mlxsw_sp *mlxsw_sp,
                                          struct netlink_ext_ack *extack)
 {
         const struct tc_action *a;
-        LIST_HEAD(actions);
-        int err;
+        int err, i;
 
         if (!tcf_exts_has_actions(exts))
                 return 0;
@@ -32,8 +31,7 @@ static int mlxsw_sp_flower_parse_actions(struct mlxsw_sp *mlxsw_sp,
         if (err)
                 return err;
 
-        tcf_exts_to_list(exts, &actions);
-        list_for_each_entry(a, &actions, list) {
+        tcf_exts_for_each_action(i, a, exts) {
                 if (is_tcf_gact_ok(a)) {
                         err = mlxsw_sp_acl_rulei_act_terminate(rulei);
                         if (err) {
diff --git a/drivers/net/ethernet/netronome/nfp/flower/action.c b/drivers/net/ethernet/netronome/nfp/flower/action.c
index 0ba0356ec4e6..9044496803e6 100644
--- a/drivers/net/ethernet/netronome/nfp/flower/action.c
+++ b/drivers/net/ethernet/netronome/nfp/flower/action.c
@@ -796,11 +796,10 @@ int nfp_flower_compile_action(struct nfp_app *app,
                               struct net_device *netdev,
                               struct nfp_fl_payload *nfp_flow)
 {
-        int act_len, act_cnt, err, tun_out_cnt, out_cnt;
+        int act_len, act_cnt, err, tun_out_cnt, out_cnt, i;
         enum nfp_flower_tun_type tun_type;
         const struct tc_action *a;
         u32 csum_updated = 0;
-        LIST_HEAD(actions);
 
         memset(nfp_flow->action_data, 0, NFP_FL_MAX_A_SIZ);
         nfp_flow->meta.act_len = 0;
@@ -810,8 +809,7 @@ int nfp_flower_compile_action(struct nfp_app *app,
         tun_out_cnt = 0;
         out_cnt = 0;
 
-        tcf_exts_to_list(flow->exts, &actions);
-        list_for_each_entry(a, &actions, list) {
+        tcf_exts_for_each_action(i, a, flow->exts) {
                 err = nfp_flower_loop_action(app, a, flow, nfp_flow, &act_len,
                                              netdev, &tun_type, &tun_out_cnt,
                                              &out_cnt, &csum_updated);
diff --git a/drivers/net/ethernet/qlogic/qede/qede_filter.c b/drivers/net/ethernet/qlogic/qede/qede_filter.c
index 9673d19308e6..b16ce7d93caf 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_filter.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_filter.c
@@ -2006,18 +2006,16 @@ unlock:
 static int qede_parse_actions(struct qede_dev *edev,
                               struct tcf_exts *exts)
 {
-        int rc = -EINVAL, num_act = 0;
+        int rc = -EINVAL, num_act = 0, i;
         const struct tc_action *a;
         bool is_drop = false;
-        LIST_HEAD(actions);
 
         if (!tcf_exts_has_actions(exts)) {
                 DP_NOTICE(edev, "No tc actions received\n");
                 return rc;
         }
 
-        tcf_exts_to_list(exts, &actions);
-        list_for_each_entry(a, &actions, list) {
+        tcf_exts_for_each_action(i, a, exts) {
                 num_act++;
 
                 if (is_tcf_gact_shot(a))
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c
index 1a96dd9c1091..531294f4978b 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c
@@ -61,7 +61,7 @@ static int tc_fill_actions(struct stmmac_tc_entry *entry,
         struct stmmac_tc_entry *action_entry = entry;
         const struct tc_action *act;
         struct tcf_exts *exts;
-        LIST_HEAD(actions);
+        int i;
 
         exts = cls->knode.exts;
         if (!tcf_exts_has_actions(exts))
@@ -69,8 +69,7 @@ static int tc_fill_actions(struct stmmac_tc_entry *entry,
         if (frag)
                 action_entry = frag;
 
-        tcf_exts_to_list(exts, &actions);
-        list_for_each_entry(act, &actions, list) {
+        tcf_exts_for_each_action(i, act, exts) {
                 /* Accept */
                 if (is_tcf_gact_ok(act)) {
                         action_entry->val.af = 1;
diff --git a/include/net/act_api.h b/include/net/act_api.h
index eaa0e8b93d5b..f9c4b871af88 100644
--- a/include/net/act_api.h
+++ b/include/net/act_api.h
@@ -23,7 +23,6 @@ struct tc_action {
         const struct tc_action_ops      *ops;
         __u32                           type; /* for backward compat(TCA_OLD_COMPAT) */
         __u32                           order;
-        struct list_head                list;
         struct tcf_idrinfo              *idrinfo;
 
         u32                             tcfa_index;
diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
index ef727f71336e..c17d51865469 100644
--- a/include/net/pkt_cls.h
+++ b/include/net/pkt_cls.h
@@ -298,19 +298,13 @@ static inline void tcf_exts_put_net(struct tcf_exts *exts)
 #endif
 }
 
-static inline void tcf_exts_to_list(const struct tcf_exts *exts,
-                                    struct list_head *actions)
-{
 #ifdef CONFIG_NET_CLS_ACT
-        int i;
-
-        for (i = 0; i < exts->nr_actions; i++) {
-                struct tc_action *a = exts->actions[i];
-
-                list_add_tail(&a->list, actions);
-        }
+#define tcf_exts_for_each_action(i, a, exts) \
+        for (i = 0; i < TCA_ACT_MAX_PRIO && ((a) = (exts)->actions[i]); i++)
+#else
+#define tcf_exts_for_each_action(i, a, exts) \
+        for (; 0; )
 #endif
-}
 
 static inline void
 tcf_exts_stats_update(const struct tcf_exts *exts,
@@ -361,6 +355,15 @@ static inline bool tcf_exts_has_one_action(struct tcf_exts *exts)
 #endif
 }
 
+static inline struct tc_action *tcf_exts_first_action(struct tcf_exts *exts)
+{
+#ifdef CONFIG_NET_CLS_ACT
+        return exts->actions[0];
+#else
+        return NULL;
+#endif
+}
+
 /**
  * tcf_exts_exec - execute tc filter extensions
  * @skb: socket buffer
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 962c4fd338ba..1c45c1d6d241 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -767,7 +767,6 @@ static int dsa_slave_add_cls_matchall(struct net_device *dev,
         const struct tc_action *a;
         struct dsa_port *to_dp;
         int err = -EOPNOTSUPP;
-        LIST_HEAD(actions);
 
         if (!ds->ops->port_mirror_add)
                 return err;
@@ -775,8 +774,7 @@ static int dsa_slave_add_cls_matchall(struct net_device *dev,
         if (!tcf_exts_has_one_action(cls->exts))
                 return err;
 
-        tcf_exts_to_list(cls->exts, &actions);
-        a = list_first_entry(&actions, struct tc_action, list);
+        a = tcf_exts_first_action(cls->exts);
 
         if (is_tcf_mirred_egress_mirror(a) && protocol == htons(ETH_P_ALL)) {
                 struct dsa_mall_mirror_tc_entry *mirror;
diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index d76948f02a02..db83dac1e7f4 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -391,7 +391,6 @@ int tcf_idr_create(struct tc_action_net *tn, u32 index, struct nlattr *est,
 
         p->idrinfo = idrinfo;
         p->ops = ops;
-        INIT_LIST_HEAD(&p->list);
         *a = p;
         return 0;
 err3: