iommu/vt-d: Avoid format string leaks into iommu_device_create

This makes sure it won't be possible to accidentally leak format
strings into iommu device names. Current name allocations are safe,
but this makes the "%s" explicit.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Joerg Roedel <jroedel@suse.de>

2 files changed, 2 insertions, 2 deletions

diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
index c9db04d4ef39..8757f8dfc4e5 100644
--- a/drivers/iommu/dmar.c
+++ b/drivers/iommu/dmar.c
@@ -1068,7 +1068,7 @@ static int alloc_iommu(struct dmar_drhd_unit *drhd)
         if (intel_iommu_enabled)
                 iommu->iommu_dev = iommu_device_create(NULL, iommu,
                                                        intel_iommu_groups,
-                                                       iommu->name);
+                                                       "%s", iommu->name);
 
         return 0;
 
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index 0649b94f5958..0be23c589d3b 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -4533,7 +4533,7 @@ int __init intel_iommu_init(void)
         for_each_active_iommu(iommu, drhd)
                 iommu->iommu_dev = iommu_device_create(NULL, iommu,
                                                        intel_iommu_groups,
-                                                       iommu->name);
+                                                       "%s", iommu->name);
 
         bus_set_iommu(&pci_bus_type, &intel_iommu_ops);
         bus_register_notifier(&pci_bus_type, &device_nb);