fw_cfg: fix driver remove

On driver remove(), all objects created during probe() should be
removed, but sysfs qemu_fw_cfg/rev file was left. Also reorder
functions to match probe() error cleanup code.

Cc: stable@vger.kernel.org
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

1 files changed, 2 insertions, 1 deletions

diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index 5cfe39f7a45f..deb483064f53 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -582,9 +582,10 @@ static int fw_cfg_sysfs_remove(struct platform_device *pdev)
 {
         pr_debug("fw_cfg: unloading.\n");
         fw_cfg_sysfs_cache_cleanup();
+        sysfs_remove_file(fw_cfg_top_ko, &fw_cfg_rev_attr.attr);
+        fw_cfg_io_cleanup();
         fw_cfg_kset_unregister_recursive(fw_cfg_fname_kset);
         fw_cfg_kobj_cleanup(fw_cfg_sel_ko);
-        fw_cfg_io_cleanup();
         return 0;
 }