Merge tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost

Pull virtio fixes from Michael Tsirkin:
 "virtio and qemu bugfixes

  A couple of bugfixes that just became ready"

* tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost:
  virtio_balloon: fix increment of vb->num_pfns in fill_balloon()
  virtio: release virtio index when fail to device_register
  fw_cfg: fix driver remove

3 files changed, 5 insertions, 3 deletions

diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index 5cfe39f7a45f..deb483064f53 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -582,9 +582,10 @@ static int fw_cfg_sysfs_remove(struct platform_device *pdev)
 {
         pr_debug("fw_cfg: unloading.\n");
         fw_cfg_sysfs_cache_cleanup();
+        sysfs_remove_file(fw_cfg_top_ko, &fw_cfg_rev_attr.attr);
+        fw_cfg_io_cleanup();
         fw_cfg_kset_unregister_recursive(fw_cfg_fname_kset);
         fw_cfg_kobj_cleanup(fw_cfg_sel_ko);
-        fw_cfg_io_cleanup();
         return 0;
 }
 
diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
index 48230a5e12f2..bf7ff3934d7f 100644
--- a/drivers/virtio/virtio.c
+++ b/drivers/virtio/virtio.c
@@ -333,6 +333,8 @@ int register_virtio_device(struct virtio_device *dev)
         /* device_register() causes the bus infrastructure to look for a
          * matching driver. */
         err = device_register(&dev->dev);
+        if (err)
+                ida_simple_remove(&virtio_index_ida, dev->index);
 out:
         if (err)
                 virtio_add_status(dev, VIRTIO_CONFIG_S_FAILED);
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 7960746f7597..a1fb52cb3f0a 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -174,13 +174,12 @@ static unsigned fill_balloon(struct virtio_balloon *vb, size_t num)
         while ((page = balloon_page_pop(&pages))) {
                 balloon_page_enqueue(&vb->vb_dev_info, page);
 
-                vb->num_pfns += VIRTIO_BALLOON_PAGES_PER_PAGE;
-
                 set_page_pfns(vb, vb->pfns + vb->num_pfns, page);
                 vb->num_pages += VIRTIO_BALLOON_PAGES_PER_PAGE;
                 if (!virtio_has_feature(vb->vdev,
                                         VIRTIO_BALLOON_F_DEFLATE_ON_OOM))
                         adjust_managed_page_count(page, -1);
+                vb->num_pfns += VIRTIO_BALLOON_PAGES_PER_PAGE;
         }
 
         num_allocated_pages = vb->num_pfns;