diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-07-16 06:07:55 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-08-21 11:28:21 -0400 |
commit | 23436825e671cdd55c45d151ddc66fd3c47d10e9 (patch) | |
tree | d040fad45214119c1232abc2a7d533c619b9658e | |
parent | 23535c1322e42e71f32bfbeae9970f4dba31e3bd (diff) |
staging: wilc1000: NULL dereference on error
We can't pass NULL pointers to destroy_workqueue().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/staging/wilc1000/host_interface.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 0b1760cba6e3..78f524fcd214 100644 --- a/drivers/staging/wilc1000/host_interface.c +++ b/drivers/staging/wilc1000/host_interface.c | |||
@@ -3363,7 +3363,7 @@ int wilc_init(struct net_device *dev, struct host_if_drv **hif_drv_handler) | |||
3363 | if (!hif_workqueue) { | 3363 | if (!hif_workqueue) { |
3364 | netdev_err(vif->ndev, "Failed to create workqueue\n"); | 3364 | netdev_err(vif->ndev, "Failed to create workqueue\n"); |
3365 | result = -ENOMEM; | 3365 | result = -ENOMEM; |
3366 | goto _fail_mq_; | 3366 | goto _fail_; |
3367 | } | 3367 | } |
3368 | 3368 | ||
3369 | setup_timer(&periodic_rssi, GetPeriodicRSSI, | 3369 | setup_timer(&periodic_rssi, GetPeriodicRSSI, |
@@ -3391,7 +3391,6 @@ int wilc_init(struct net_device *dev, struct host_if_drv **hif_drv_handler) | |||
3391 | 3391 | ||
3392 | clients_count++; | 3392 | clients_count++; |
3393 | 3393 | ||
3394 | _fail_mq_: | ||
3395 | destroy_workqueue(hif_workqueue); | 3394 | destroy_workqueue(hif_workqueue); |
3396 | _fail_: | 3395 | _fail_: |
3397 | return result; | 3396 | return result; |