aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTrond Myklebust <trond.myklebust@primarydata.com>2017-07-12 19:10:59 -0400
committerAnna Schumaker <Anna.Schumaker@Netapp.com>2017-07-19 15:28:21 -0400
commit213297369cf4900eba906dd32ce845074e30f487 (patch)
tree08d79c933859686df4b902b86f247cd17b95ce14
parent4b75053e9bb6db4b700526d2d67c67a0d07f867e (diff)
Revert commit 722f0b891198 ("pNFS: Don't send COMMITs to the DSes if...")
Doing the test without taking any locks is racy, and so really it makes more sense to do it in the flexfiles code (which is the only case that cares). Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
-rw-r--r--fs/nfs/pnfs_nfs.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/fs/nfs/pnfs_nfs.c b/fs/nfs/pnfs_nfs.c
index 7ceb86627e54..25f28fa64c57 100644
--- a/fs/nfs/pnfs_nfs.c
+++ b/fs/nfs/pnfs_nfs.c
@@ -224,13 +224,6 @@ pnfs_generic_alloc_ds_commits(struct nfs_commit_info *cinfo,
224 for (i = 0; i < fl_cinfo->nbuckets; i++, bucket++) { 224 for (i = 0; i < fl_cinfo->nbuckets; i++, bucket++) {
225 if (list_empty(&bucket->committing)) 225 if (list_empty(&bucket->committing))
226 continue; 226 continue;
227 /*
228 * If the layout segment is invalid, then let
229 * pnfs_generic_retry_commit() clean up the bucket.
230 */
231 if (bucket->clseg && !pnfs_is_valid_lseg(bucket->clseg) &&
232 !test_bit(NFS_LSEG_LAYOUTRETURN, &bucket->clseg->pls_flags))
233 break;
234 data = nfs_commitdata_alloc(false); 227 data = nfs_commitdata_alloc(false);
235 if (!data) 228 if (!data)
236 break; 229 break;