diff options
author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2018-11-27 23:33:54 -0500 |
---|---|---|
committer | Martin K. Petersen <martin.petersen@oracle.com> | 2019-01-11 21:41:24 -0500 |
commit | 211d62a8ce689bf8e7fd0ede67b3a6b1d8de970b (patch) | |
tree | b5ee91d05f818c86b5e9149bb8b883105980a2d4 | |
parent | fc9ac87eabb23b4c354cd2f3b89d94a0db9f9fdc (diff) |
scsi: st: mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where
we are expecting to fall through.
Addresses-Coverity-ID: 114994 ("Missing break in switch")
Addresses-Coverity-ID: 114995 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Kai Mäkisara <kai.makisara@kolumbus.fi>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
-rw-r--r-- | drivers/scsi/st.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index 7ff22d3f03e3..7c7a742a5ef7 100644 --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c | |||
@@ -337,12 +337,14 @@ static void st_analyze_sense(struct st_request *SRpnt, struct st_cmdstatus *s) | |||
337 | switch (sense[0] & 0x7f) { | 337 | switch (sense[0] & 0x7f) { |
338 | case 0x71: | 338 | case 0x71: |
339 | s->deferred = 1; | 339 | s->deferred = 1; |
340 | /* fall through */ | ||
340 | case 0x70: | 341 | case 0x70: |
341 | s->fixed_format = 1; | 342 | s->fixed_format = 1; |
342 | s->flags = sense[2] & 0xe0; | 343 | s->flags = sense[2] & 0xe0; |
343 | break; | 344 | break; |
344 | case 0x73: | 345 | case 0x73: |
345 | s->deferred = 1; | 346 | s->deferred = 1; |
347 | /* fall through */ | ||
346 | case 0x72: | 348 | case 0x72: |
347 | s->fixed_format = 0; | 349 | s->fixed_format = 0; |
348 | ucp = scsi_sense_desc_find(sense, SCSI_SENSE_BUFFERSIZE, 4); | 350 | ucp = scsi_sense_desc_find(sense, SCSI_SENSE_BUFFERSIZE, 4); |
@@ -2721,6 +2723,7 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned int cmd_in, unsigned lon | |||
2721 | switch (cmd_in) { | 2723 | switch (cmd_in) { |
2722 | case MTFSFM: | 2724 | case MTFSFM: |
2723 | chg_eof = 0; /* Changed from the FSF after this */ | 2725 | chg_eof = 0; /* Changed from the FSF after this */ |
2726 | /* fall through */ | ||
2724 | case MTFSF: | 2727 | case MTFSF: |
2725 | cmd[0] = SPACE; | 2728 | cmd[0] = SPACE; |
2726 | cmd[1] = 0x01; /* Space FileMarks */ | 2729 | cmd[1] = 0x01; /* Space FileMarks */ |
@@ -2735,6 +2738,7 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned int cmd_in, unsigned lon | |||
2735 | break; | 2738 | break; |
2736 | case MTBSFM: | 2739 | case MTBSFM: |
2737 | chg_eof = 0; /* Changed from the FSF after this */ | 2740 | chg_eof = 0; /* Changed from the FSF after this */ |
2741 | /* fall through */ | ||
2738 | case MTBSF: | 2742 | case MTBSF: |
2739 | cmd[0] = SPACE; | 2743 | cmd[0] = SPACE; |
2740 | cmd[1] = 0x01; /* Space FileMarks */ | 2744 | cmd[1] = 0x01; /* Space FileMarks */ |