aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVivien Didelot <vivien.didelot@savoirfairelinux.com>2017-11-08 10:50:10 -0500
committerDavid S. Miller <davem@davemloft.net>2017-11-11 01:45:09 -0500
commit2118df93b5e1742931da358c2b8804c46fd64490 (patch)
tree164f16f86631b705edea08104baa9dd30bc60ae8
parentb0b38a1c6684b10dd0462bef4fef038917115012 (diff)
net: dsa: return after vlan prepare phase
The current code does not return after successfully preparing the VLAN addition on every ports member of a it. Fix this. Fixes: 1ca4aa9cd4cc ("net: dsa: check VLAN capability of every switch") Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/dsa/switch.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/net/dsa/switch.c b/net/dsa/switch.c
index 73746fa148f1..1e2929f4290a 100644
--- a/net/dsa/switch.c
+++ b/net/dsa/switch.c
@@ -182,6 +182,8 @@ static int dsa_switch_vlan_add(struct dsa_switch *ds,
182 if (err) 182 if (err)
183 return err; 183 return err;
184 } 184 }
185
186 return 0;
185 } 187 }
186 188
187 for_each_set_bit(port, members, ds->num_ports) 189 for_each_set_bit(port, members, ds->num_ports)