aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFrederic Weisbecker <fweisbec@gmail.com>2014-10-27 12:20:35 -0400
committerFrederic Weisbecker <fweisbec@gmail.com>2015-07-29 09:44:58 -0400
commit2019e8a3024bd8fcadd57891a88c838849216a5f (patch)
tree3cb521befc3eec3c2ac7383a9890ea115e329d4c
parent031a7f456adecaff692bc040b31a7d2262b4ee56 (diff)
alpha: Fix jiffies based cputime assumption
That code wrongly assumes that cputime_t wraps jiffies_t. Lets use the correct accessors/mutators. In practice there should be no harm yet because alpha currently only support tick based cputime accounting which is always jiffies based. Reviewed-by: Rik van Riel <riel@redhat.com> Cc: Richard Henderson <rth@twiddle.net> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> Cc: Christoph Lameter <cl@linux.com> Cc: Ingo Molnar <mingo@kernel.org> Cc; John Stultz <john.stultz@linaro.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Preeti U Murthy <preeti@linux.vnet.ibm.com> Cc: Rik van Riel <riel@redhat.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
-rw-r--r--arch/alpha/kernel/osf_sys.c13
1 files changed, 9 insertions, 4 deletions
diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c
index 36dc91ace83a..6cc08166ff00 100644
--- a/arch/alpha/kernel/osf_sys.c
+++ b/arch/alpha/kernel/osf_sys.c
@@ -1138,6 +1138,7 @@ SYSCALL_DEFINE2(osf_getrusage, int, who, struct rusage32 __user *, ru)
1138{ 1138{
1139 struct rusage32 r; 1139 struct rusage32 r;
1140 cputime_t utime, stime; 1140 cputime_t utime, stime;
1141 unsigned long utime_jiffies, stime_jiffies;
1141 1142
1142 if (who != RUSAGE_SELF && who != RUSAGE_CHILDREN) 1143 if (who != RUSAGE_SELF && who != RUSAGE_CHILDREN)
1143 return -EINVAL; 1144 return -EINVAL;
@@ -1146,14 +1147,18 @@ SYSCALL_DEFINE2(osf_getrusage, int, who, struct rusage32 __user *, ru)
1146 switch (who) { 1147 switch (who) {
1147 case RUSAGE_SELF: 1148 case RUSAGE_SELF:
1148 task_cputime(current, &utime, &stime); 1149 task_cputime(current, &utime, &stime);
1149 jiffies_to_timeval32(utime, &r.ru_utime); 1150 utime_jiffies = cputime_to_jiffies(utime);
1150 jiffies_to_timeval32(stime, &r.ru_stime); 1151 stime_jiffies = cputime_to_jiffies(stime);
1152 jiffies_to_timeval32(utime_jiffies, &r.ru_utime);
1153 jiffies_to_timeval32(stime_jiffies, &r.ru_stime);
1151 r.ru_minflt = current->min_flt; 1154 r.ru_minflt = current->min_flt;
1152 r.ru_majflt = current->maj_flt; 1155 r.ru_majflt = current->maj_flt;
1153 break; 1156 break;
1154 case RUSAGE_CHILDREN: 1157 case RUSAGE_CHILDREN:
1155 jiffies_to_timeval32(current->signal->cutime, &r.ru_utime); 1158 utime_jiffies = cputime_to_jiffies(current->signal->cutime);
1156 jiffies_to_timeval32(current->signal->cstime, &r.ru_stime); 1159 stime_jiffies = cputime_to_jiffies(current->signal->cstime);
1160 jiffies_to_timeval32(utime_jiffies, &r.ru_utime);
1161 jiffies_to_timeval32(stime_jiffies, &r.ru_stime);
1157 r.ru_minflt = current->signal->cmin_flt; 1162 r.ru_minflt = current->signal->cmin_flt;
1158 r.ru_majflt = current->signal->cmaj_flt; 1163 r.ru_majflt = current->signal->cmaj_flt;
1159 break; 1164 break;