ARC: Re-enable MMU upon Machine Check exception

I recently came upon a scenario where I would get a double fault
machine check exception tiriggered by a kernel module.
However the ensuing crash stacktrace (ksym lookup) was not working
correctly.

Turns out that machine check auto-disables MMU while modules are allocated
in kernel vaddr spapce.

This patch re-enables the MMU before start printing the stacktrace
making stacktracing of modules work upon a fatal exception.

Cc: stable@kernel.org
Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Reviewed-by: Alexey Brodkin <abrodkin@synopsys.com>
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
[vgupta: moved code into low level handler to avoid in 2 places]

2 files changed, 6 insertions, 3 deletions

diff --git a/arch/arc/kernel/entry.S b/arch/arc/kernel/entry.S
index 1eea99beecc3..85d9ea4a0acc 100644
--- a/arch/arc/kernel/entry.S
+++ b/arch/arc/kernel/entry.S
@@ -92,6 +92,12 @@ ENTRY(EV_MachineCheck)
         lr  r0, [efa]
         mov r1, sp
 
+        ; hardware auto-disables MMU, re-enable it to allow kernel vaddr
+        ; access for say stack unwinding of modules for crash dumps
+        lr      r3, [ARC_REG_PID]
+        or      r3, r3, MMU_ENABLE
+        sr      r3, [ARC_REG_PID]
+
         lsr     r3, r2, 8
         bmsk    r3, r3, 7
         brne    r3, ECR_C_MCHK_DUP_TLB, 1f
diff --git a/arch/arc/mm/tlb.c b/arch/arc/mm/tlb.c
index edc59a0a9c9b..8ceefbf72fb0 100644
--- a/arch/arc/mm/tlb.c
+++ b/arch/arc/mm/tlb.c
@@ -908,9 +908,6 @@ void do_tlb_overlap_fault(unsigned long cause, unsigned long address,
 
         local_irq_save(flags);
 
-        /* re-enable the MMU */
-        write_aux_reg(ARC_REG_PID, MMU_ENABLE | read_aux_reg(ARC_REG_PID));
-
         /* loop thru all sets of TLB */
         for (set = 0; set < mmu->sets; set++) {