diff options
author | Hans de Goede <hdegoede@redhat.com> | 2018-09-10 14:30:38 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-09-11 12:39:54 -0400 |
commit | 1ebafd1561a05ea7868f46d88420fe9323f981f6 (patch) | |
tree | 6887d65d1e9afb1eaac181a12d69a7a342c1a11c | |
parent | 383584157786e09fed6d9e87b2cd8784b6709216 (diff) |
staging: vboxvideo: Fix IRQs no longer working
Commit 1daddbc8dec5 ("staging: vboxvideo: Update driver to use
drm_dev_register.") replaced the obsolere drm_get_pci_dev() with
normal pci probe and remove functions.
But the new vbox_pci_probe() is missing a pci_enable_device() call,
causing interrupts to not be delivered. This causes resizes of the
vm window to not get seen by the drm/kms code.
This commit adds the missing pci_enable_device() call, fixing this.
Fixes: 1daddbc8dec5 ("staging: vboxvideo: Update driver to use ...")
Cc: Fabio Rafael da Rosa <fdr@pid42.net>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Nicholas Mc Guire <der.herr@hofr.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/staging/vboxvideo/vbox_drv.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/staging/vboxvideo/vbox_drv.c b/drivers/staging/vboxvideo/vbox_drv.c index da92c493f157..69cc508af1bc 100644 --- a/drivers/staging/vboxvideo/vbox_drv.c +++ b/drivers/staging/vboxvideo/vbox_drv.c | |||
@@ -59,6 +59,11 @@ static int vbox_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
59 | ret = PTR_ERR(dev); | 59 | ret = PTR_ERR(dev); |
60 | goto err_drv_alloc; | 60 | goto err_drv_alloc; |
61 | } | 61 | } |
62 | |||
63 | ret = pci_enable_device(pdev); | ||
64 | if (ret) | ||
65 | goto err_pci_enable; | ||
66 | |||
62 | dev->pdev = pdev; | 67 | dev->pdev = pdev; |
63 | pci_set_drvdata(pdev, dev); | 68 | pci_set_drvdata(pdev, dev); |
64 | 69 | ||
@@ -75,6 +80,8 @@ static int vbox_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) | |||
75 | err_drv_dev_register: | 80 | err_drv_dev_register: |
76 | vbox_driver_unload(dev); | 81 | vbox_driver_unload(dev); |
77 | err_vbox_driver_load: | 82 | err_vbox_driver_load: |
83 | pci_disable_device(pdev); | ||
84 | err_pci_enable: | ||
78 | drm_dev_put(dev); | 85 | drm_dev_put(dev); |
79 | err_drv_alloc: | 86 | err_drv_alloc: |
80 | return ret; | 87 | return ret; |