diff options
author | Colin Ian King <colin.king@canonical.com> | 2017-06-06 09:10:49 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-06-06 16:26:28 -0400 |
commit | 1d3028f4c16487d63861ab6c68451768a7a109df (patch) | |
tree | fc7e5b6114f4684d2ce8bc5410a1b849ce37255b | |
parent | 426849e6611f2092553f8d53372ae310818a6292 (diff) |
net: stmmac: fix a broken u32 less than zero check
The check that queue is less or equal to zero is always true
because queue is a u32; queue is decremented and will wrap around
and never go -ve. Fix this by making queue an int.
Detected by CoverityScan, CID#1428988 ("Unsigned compared against 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index dcbe4537ad99..12236daf7bb6 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | |||
@@ -1208,7 +1208,7 @@ static int init_dma_rx_desc_rings(struct net_device *dev, gfp_t flags) | |||
1208 | u32 rx_count = priv->plat->rx_queues_to_use; | 1208 | u32 rx_count = priv->plat->rx_queues_to_use; |
1209 | unsigned int bfsize = 0; | 1209 | unsigned int bfsize = 0; |
1210 | int ret = -ENOMEM; | 1210 | int ret = -ENOMEM; |
1211 | u32 queue; | 1211 | int queue; |
1212 | int i; | 1212 | int i; |
1213 | 1213 | ||
1214 | if (priv->hw->mode->set_16kib_bfsize) | 1214 | if (priv->hw->mode->set_16kib_bfsize) |