diff options
| author | Bart Van Assche <bart.vanassche@wdc.com> | 2017-08-09 14:32:12 -0400 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2017-08-28 09:58:27 -0400 |
| commit | 1c23484c355ec360ca2f37914f8a4802c6baeead (patch) | |
| tree | 8825a50d4c93409de59318edf975023cbd3fc907 | |
| parent | 604407890ecf624c2fb41013c82b22aade59b455 (diff) | |
dm mpath: do not lock up a CPU with requeuing activity
When using the block layer in single queue mode, get_request()
returns ERR_PTR(-EAGAIN) if the queue is dying and the REQ_NOWAIT
flag has been passed to get_request(). Avoid that the kernel
reports soft lockup complaints in this case due to continuous
requeuing activity.
Fixes: 7083abbbf ("dm mpath: avoid that path removal can trigger an infinite loop")
Cc: stable@vger.kernel.org
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Tested-by: Laurence Oberman <loberman@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
| -rw-r--r-- | drivers/md/dm-mpath.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c index 3486c829fa50..d24e4b05f5da 100644 --- a/drivers/md/dm-mpath.c +++ b/drivers/md/dm-mpath.c | |||
| @@ -504,7 +504,6 @@ static int multipath_clone_and_map(struct dm_target *ti, struct request *rq, | |||
| 504 | if (queue_dying) { | 504 | if (queue_dying) { |
| 505 | atomic_inc(&m->pg_init_in_progress); | 505 | atomic_inc(&m->pg_init_in_progress); |
| 506 | activate_or_offline_path(pgpath); | 506 | activate_or_offline_path(pgpath); |
| 507 | return DM_MAPIO_REQUEUE; | ||
| 508 | } | 507 | } |
| 509 | return DM_MAPIO_DELAY_REQUEUE; | 508 | return DM_MAPIO_DELAY_REQUEUE; |
| 510 | } | 509 | } |
